| Message ID | 20240204-keee-u32-cleanup-v1-0-fb6e08329d9a@lunn.ch (mailing list archive) |
|---|---|
| Headers | show |
| Series | drivers: net: Convert EEE handling to use linkmode bitmaps | expand |
On Sun, Feb 04, 2024 at 05:40:17PM -0600, Andrew Lunn wrote: > EEE has until recently been limited to lower speeds due to the use of > the legacy u32 for link speeds. This restriction has been lifted, with > the use of linkmode bitmaps. This patchset convert some MAC drivers > still using the old _u32 to link modes, with the aim of soon being > able to remove the legacy _u32 members in the keee structure. > > A couple of Intel drivers do odd things with EEE, setting the autoneg > bit. It is unclear why, no other driver does, ethtool does not display > it, and EEE is always negotiated. One patch in this series deletes > this code. Comments on why its actually useful and should be kept are > gratefully received. Gerr. How many people have i said to put the tree in the Subject: And then i forget myself :-( net-next. Andrew
Hello Andrew, On Sun, 04 Feb 2024 17:40:17 -0600 Andrew Lunn <andrew@lunn.ch> wrote: > EEE has until recently been limited to lower speeds due to the use of > the legacy u32 for link speeds. This restriction has been lifted, with > the use of linkmode bitmaps. This patchset convert some MAC drivers > still using the old _u32 to link modes, with the aim of soon being > able to remove the legacy _u32 members in the keee structure. Although I don't have proper hardware to test all these, I've read the patches and I didn't find any obvious issues besides the typo in patch 7. Regards, Maxime
EEE has until recently been limited to lower speeds due to the use of the legacy u32 for link speeds. This restriction has been lifted, with the use of linkmode bitmaps. This patchset convert some MAC drivers still using the old _u32 to link modes, with the aim of soon being able to remove the legacy _u32 members in the keee structure. A couple of Intel drivers do odd things with EEE, setting the autoneg bit. It is unclear why, no other driver does, ethtool does not display it, and EEE is always negotiated. One patch in this series deletes this code. Comments on why its actually useful and should be kept are gratefully received. Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- Andrew Lunn (8): net: usb: r8152: Use linkmode helpers for EEE net: usb: ax88179_178a: Use linkmode helpers for EEE net: qlogic: qede: Use linkmode helpers for EEE net: ethernet: ixgbe: Convert EEE to use linkmodes net: intel: i40e/igc: Remove setting Autoneg in EEE capabilities net: intel: e1000e: Use linkmode helpers for EEE net: intel: igb: Use linkmode helpers for EEE net: intel: igc: Use linkmode helpers for EEE drivers/net/ethernet/intel/e1000e/ethtool.c | 17 +++++-- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 +-- drivers/net/ethernet/intel/igb/igb_ethtool.c | 33 ++++++++----- drivers/net/ethernet/intel/igc/igc_ethtool.c | 13 ++--- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 48 ++++++++++--------- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60 +++++++++++++++--------- drivers/net/usb/Kconfig | 1 + drivers/net/usb/ax88179_178a.c | 9 ++-- drivers/net/usb/r8152.c | 31 ++++++------ 9 files changed, 123 insertions(+), 96 deletions(-) --- base-commit: ffabe98cb576097b77d404d39e8b3df03caa986a change-id: 20240204-keee-u32-cleanup-b86d68458d80 Best regards,