| Message ID | 20240206135115.151218-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RZ/G2L pinctrl trivial changes | expand |
+ IRQchip > -----Original Message----- > From: Biju Das <biju.das.jz@bp.renesas.com> > Sent: Tuesday, February 6, 2024 1:51 PM > To: Linus Walleij <linus.walleij@linaro.org> > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Geert Uytterhoeven > <geert+renesas@glider.be>; linux-renesas-soc@vger.kernel.org; linux- > gpio@vger.kernel.org; Prabhakar Mahadev Lad <prabhakar.mahadev- > lad.rj@bp.renesas.com>; biju.das.au <biju.das.au@gmail.com> > Subject: [PATCH v2 0/3] RZ/G2L pinctrl trivial changes > > The first patch in this series for configuring GPIO interrupt as input > mode. Also if the bootloader sets gpio interrupt pin as function, override > it as gpio. > > The second and third patch is satisfy the prerequisite for IA55 tint > registers(ie, pin will be always in gpioint mode) > > Currently on irq_disable(), we are disabling gpio interrupt enable(ISEL). > That means the pin is just gpio input and not gpio input interrupt any > more. So, move configuring ISEL in rzg2l_gpio_child_to_parent_hwirq()/ > rzg2l_gpio_irq_domain_free() so that pin will be gpioint always even > during irq_disable(). > > v1->v2: > * Added as series by adding patch#2 and #3. > * Replaced u32->u64 for pin_data > * Added rzg2l_gpio_free() for error path for bitmap_find_free_region(). > * rzg2l_gpio_free() called during rzg2l_gpio_irq_domain_free(). > > Biju Das (3): > pinctrl: renesas: rzg2l: Configure interrupt input mode > pinctrl: renesas: rzg2l: Simplify rzg2l_gpio_irq_{en,dis}able > pinctrl: renesas: rzg2l: Avoid configuring ISEL in > gpio_irq_{en,dis}able > > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 77 ++++++++++++++++--------- > 1 file changed, 50 insertions(+), 27 deletions(-) > > -- > 2.25.1
On Tue, Feb 6, 2024 at 3:10 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > -----Original Message----- > > From: Biju Das <biju.das.jz@bp.renesas.com> > > Sent: Tuesday, February 6, 2024 1:51 PM > > To: Linus Walleij <linus.walleij@linaro.org> > > Cc: Biju Das <biju.das.jz@bp.renesas.com>; Geert Uytterhoeven > > <geert+renesas@glider.be>; linux-renesas-soc@vger.kernel.org; linux- > > gpio@vger.kernel.org; Prabhakar Mahadev Lad <prabhakar.mahadev- > > lad.rj@bp.renesas.com>; biju.das.au <biju.das.au@gmail.com> > > Subject: [PATCH v2 0/3] RZ/G2L pinctrl trivial changes > > > > The first patch in this series for configuring GPIO interrupt as input > > mode. Also if the bootloader sets gpio interrupt pin as function, override > > it as gpio. > > > > The second and third patch is satisfy the prerequisite for IA55 tint > > registers(ie, pin will be always in gpioint mode) > > > > Currently on irq_disable(), we are disabling gpio interrupt enable(ISEL). > > That means the pin is just gpio input and not gpio input interrupt any > > more. So, move configuring ISEL in rzg2l_gpio_child_to_parent_hwirq()/ > > rzg2l_gpio_irq_domain_free() so that pin will be gpioint always even > > during irq_disable(). > > > > v1->v2: > > * Added as series by adding patch#2 and #3. > > * Replaced u32->u64 for pin_data > > * Added rzg2l_gpio_free() for error path for bitmap_find_free_region(). > > * rzg2l_gpio_free() called during rzg2l_gpio_irq_domain_free(). > > > > Biju Das (3): > > pinctrl: renesas: rzg2l: Configure interrupt input mode > > pinctrl: renesas: rzg2l: Simplify rzg2l_gpio_irq_{en,dis}able > > pinctrl: renesas: rzg2l: Avoid configuring ISEL in > > gpio_irq_{en,dis}able Thanks, will queue in renesas-pinctrl for v6.9. Gr{oetje,eeting}s, Geert
The first patch in this series for configuring GPIO interrupt as input mode. Also if the bootloader sets gpio interrupt pin as function, override it as gpio. The second and third patch is satisfy the prerequisite for IA55 tint registers(ie, pin will be always in gpioint mode) Currently on irq_disable(), we are disabling gpio interrupt enable(ISEL). That means the pin is just gpio input and not gpio input interrupt any more. So, move configuring ISEL in rzg2l_gpio_child_to_parent_hwirq()/ rzg2l_gpio_irq_domain_free() so that pin will be gpioint always even during irq_disable(). v1->v2: * Added as series by adding patch#2 and #3. * Replaced u32->u64 for pin_data * Added rzg2l_gpio_free() for error path for bitmap_find_free_region(). * rzg2l_gpio_free() called during rzg2l_gpio_irq_domain_free(). Biju Das (3): pinctrl: renesas: rzg2l: Configure interrupt input mode pinctrl: renesas: rzg2l: Simplify rzg2l_gpio_irq_{en,dis}able pinctrl: renesas: rzg2l: Avoid configuring ISEL in gpio_irq_{en,dis}able drivers/pinctrl/renesas/pinctrl-rzg2l.c | 77 ++++++++++++++++--------- 1 file changed, 50 insertions(+), 27 deletions(-)