diff mbox series

[blktests,v1,1/5] nvme/029: fix local variable declarations

Message ID 20240206131655.32050-2-dwagner@suse.de (mailing list archive)
State New, archived
Headers show
Series fc transport cleanups | expand

Commit Message

Daniel Wagner Feb. 6, 2024, 1:16 p.m. UTC
The syntax for local variables declarations uses whitespace as separator
and not commas:

tests/nvme/029: line 24: local: `bs,': not a valid identifier
tests/nvme/029: line 24: local: `size,': not a valid identifier
tests/nvme/029: line 24: local: `img,': not a valid identifier

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 tests/nvme/029 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chaitanya Kulkarni Feb. 6, 2024, 10:54 p.m. UTC | #1
On 2/6/2024 5:16 AM, Daniel Wagner wrote:
> The syntax for local variables declarations uses whitespace as separator
> and not commas:
> 
> tests/nvme/029: line 24: local: `bs,': not a valid identifier
> tests/nvme/029: line 24: local: `size,': not a valid identifier
> tests/nvme/029: line 24: local: `img,': not a valid identifier
> 
> Signed-off-by: Daniel Wagner <dwagner@suse.de>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
diff mbox series

Patch

diff --git a/tests/nvme/029 b/tests/nvme/029
index caed0f7ec476..db6e8b91f707 100755
--- a/tests/nvme/029
+++ b/tests/nvme/029
@@ -21,7 +21,7 @@  test_user_io()
 	local disk="$1"
 	local start=$2
 	local cnt=$3
-	local bs, size, img, img1
+	local bs size img img1
 
 	bs="$(blockdev --getss "$disk")"
 	size=$((cnt * bs))