| Message ID | 20240202213846.1775983-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | pull request: bluetooth 2024-02-02 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Pull request for net |
| netdev/build_32bit | success | Errors and warnings before: 1066 this patch: 1066 |
| netdev/build_tools | success | No tools touched, skip |
| netdev/build_clang | success | Errors and warnings before: 1081 this patch: 1081 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | fail | Problems with Fixes tag: 1 |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1083 this patch: 1083 |
| netdev/build_clang_rust | success | No Rust files in patch. Skipping build |
| netdev/contest | success | net-next-2024-02-04--21-00 (tests: 721) |
Hi, On Fri, 2024-02-02 at 16:38 -0500, Luiz Augusto von Dentz wrote: > The following changes since commit ba5e1272142d051dcc57ca1d3225ad8a089f9858: > > netdevsim: avoid potential loop in nsim_dev_trap_report_work() (2024-02-02 11:00:38 -0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-02-02 > > for you to fetch changes up to 96d874780bf5b6352e45b4c07c247e37d50263c3: > > Bluetooth: qca: Fix triggering coredump implementation (2024-02-02 16:13:56 -0500) > > ---------------------------------------------------------------- > bluetooth pull request for net: A couple of commits have some issue in the tag area (spaces between Fixes and other tag): > > - btintel: Fix null ptr deref in btintel_read_version > - mgmt: Fix limited discoverable off timeout > - hci_qca: Set BDA quirk bit if fwnode exists in DT this one ^^^ > - hci_bcm4377: do not mark valid bd_addr as invalid > - hci_sync: Check the correct flag before starting a scan > - Enforce validation on max value of connection interval and this one ^^^ Would you mind rebasing and resend the PR? Thanks! Paolo
Hi Paolo, On Tue, Feb 6, 2024 at 9:33 AM Paolo Abeni <pabeni@redhat.com> wrote: > > Hi, > > On Fri, 2024-02-02 at 16:38 -0500, Luiz Augusto von Dentz wrote: > > The following changes since commit ba5e1272142d051dcc57ca1d3225ad8a089f9858: > > > > netdevsim: avoid potential loop in nsim_dev_trap_report_work() (2024-02-02 11:00:38 -0800) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-02-02 > > > > for you to fetch changes up to 96d874780bf5b6352e45b4c07c247e37d50263c3: > > > > Bluetooth: qca: Fix triggering coredump implementation (2024-02-02 16:13:56 -0500) > > > > ---------------------------------------------------------------- > > bluetooth pull request for net: > > A couple of commits have some issue in the tag area (spaces between > Fixes and other tag): > > > > - btintel: Fix null ptr deref in btintel_read_version > > - mgmt: Fix limited discoverable off timeout > > - hci_qca: Set BDA quirk bit if fwnode exists in DT > > this one ^^^ > > > - hci_bcm4377: do not mark valid bd_addr as invalid > > - hci_sync: Check the correct flag before starting a scan > > - Enforce validation on max value of connection interval > > and this one ^^^ Ok, do you use any tools to capture these? checkpatch at least didn't capture anything for me. > Would you mind rebasing and resend the PR? > > Thanks! > > Paolo > >
Hi Paolo, On Tue, Feb 6, 2024 at 9:45 AM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: > > Hi Paolo, > > On Tue, Feb 6, 2024 at 9:33 AM Paolo Abeni <pabeni@redhat.com> wrote: > > > > Hi, > > > > On Fri, 2024-02-02 at 16:38 -0500, Luiz Augusto von Dentz wrote: > > > The following changes since commit ba5e1272142d051dcc57ca1d3225ad8a089f9858: > > > > > > netdevsim: avoid potential loop in nsim_dev_trap_report_work() (2024-02-02 11:00:38 -0800) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-02-02 > > > > > > for you to fetch changes up to 96d874780bf5b6352e45b4c07c247e37d50263c3: > > > > > > Bluetooth: qca: Fix triggering coredump implementation (2024-02-02 16:13:56 -0500) > > > > > > ---------------------------------------------------------------- > > > bluetooth pull request for net: > > > > A couple of commits have some issue in the tag area (spaces between > > Fixes and other tag): > > > > > > - btintel: Fix null ptr deref in btintel_read_version > > > - mgmt: Fix limited discoverable off timeout > > > - hci_qca: Set BDA quirk bit if fwnode exists in DT > > > > this one ^^^ > > > > > - hci_bcm4377: do not mark valid bd_addr as invalid > > > - hci_sync: Check the correct flag before starting a scan > > > - Enforce validation on max value of connection interval > > > > and this one ^^^ > > Ok, do you use any tools to capture these? checkpatch at least didn't > capture anything for me. So I rebase it locally checking if each Fixes tag actually points to a valid commit, all of them seem fine, what I found to be a little different is that those 2 have an empty line added after them, is this the problem? > > Would you mind rebasing and resend the PR? > > > > Thanks! > > > > Paolo > > > > > > > -- > Luiz Augusto von Dentz
On Tue, 2024-02-06 at 09:45 -0500, Luiz Augusto von Dentz wrote: > On Tue, Feb 6, 2024 at 9:33 AM Paolo Abeni <pabeni@redhat.com> wrote: > > On Fri, 2024-02-02 at 16:38 -0500, Luiz Augusto von Dentz wrote: > > > The following changes since commit ba5e1272142d051dcc57ca1d3225ad8a089f9858: > > > > > > netdevsim: avoid potential loop in nsim_dev_trap_report_work() (2024-02-02 11:00:38 -0800) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-02-02 > > > > > > for you to fetch changes up to 96d874780bf5b6352e45b4c07c247e37d50263c3: > > > > > > Bluetooth: qca: Fix triggering coredump implementation (2024-02-02 16:13:56 -0500) > > > > > > ---------------------------------------------------------------- > > > bluetooth pull request for net: > > > > A couple of commits have some issue in the tag area (spaces between > > Fixes and other tag): > > > > > > - btintel: Fix null ptr deref in btintel_read_version > > > - mgmt: Fix limited discoverable off timeout > > > - hci_qca: Set BDA quirk bit if fwnode exists in DT > > > > this one ^^^ > > > > > - hci_bcm4377: do not mark valid bd_addr as invalid > > > - hci_sync: Check the correct flag before starting a scan > > > - Enforce validation on max value of connection interval > > > > and this one ^^^ > > Ok, do you use any tools to capture these? checkpatch at least didn't > capture anything for me. We use the nipa tools: https://github.com/linux-netdev/nipa specifically: https://github.com/linux-netdev/nipa/blob/main/tests/patch/verify_fixes/verify_fixes.sh (it can run standalone) Cheers, Paolo
Hi Paolo, On Tue, Feb 6, 2024 at 10:21 AM Paolo Abeni <pabeni@redhat.com> wrote: > > On Tue, 2024-02-06 at 09:45 -0500, Luiz Augusto von Dentz wrote: > > On Tue, Feb 6, 2024 at 9:33 AM Paolo Abeni <pabeni@redhat.com> wrote: > > > On Fri, 2024-02-02 at 16:38 -0500, Luiz Augusto von Dentz wrote: > > > > The following changes since commit ba5e1272142d051dcc57ca1d3225ad8a089f9858: > > > > > > > > netdevsim: avoid potential loop in nsim_dev_trap_report_work() (2024-02-02 11:00:38 -0800) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-02-02 > > > > > > > > for you to fetch changes up to 96d874780bf5b6352e45b4c07c247e37d50263c3: > > > > > > > > Bluetooth: qca: Fix triggering coredump implementation (2024-02-02 16:13:56 -0500) > > > > > > > > ---------------------------------------------------------------- > > > > bluetooth pull request for net: > > > > > > A couple of commits have some issue in the tag area (spaces between > > > Fixes and other tag): > > > > > > > > - btintel: Fix null ptr deref in btintel_read_version > > > > - mgmt: Fix limited discoverable off timeout > > > > - hci_qca: Set BDA quirk bit if fwnode exists in DT > > > > > > this one ^^^ > > > > > > > - hci_bcm4377: do not mark valid bd_addr as invalid > > > > - hci_sync: Check the correct flag before starting a scan > > > > - Enforce validation on max value of connection interval > > > > > > and this one ^^^ > > > > Ok, do you use any tools to capture these? checkpatch at least didn't > > capture anything for me. > > We use the nipa tools: > > https://github.com/linux-netdev/nipa > > specifically: > > https://github.com/linux-netdev/nipa/blob/main/tests/patch/verify_fixes/verify_fixes.sh > > (it can run standalone) verify_fixes.sh HEAD^..HEAD verify_fixes.sh: line 201: $DESC_FD: ambiguous redirect Not really sure where DESC_FD comes from, perhaps it needs to be set in the environment, anyway can you send the output it is generating? > Cheers, > > Paolo >
On Tue, 2024-02-06 at 10:32 -0500, Luiz Augusto von Dentz wrote: > Hi Paolo, > > On Tue, Feb 6, 2024 at 10:21 AM Paolo Abeni <pabeni@redhat.com> wrote: > > > > On Tue, 2024-02-06 at 09:45 -0500, Luiz Augusto von Dentz wrote: > > > On Tue, Feb 6, 2024 at 9:33 AM Paolo Abeni <pabeni@redhat.com> wrote: > > > > On Fri, 2024-02-02 at 16:38 -0500, Luiz Augusto von Dentz wrote: > > > > > The following changes since commit ba5e1272142d051dcc57ca1d3225ad8a089f9858: > > > > > > > > > > netdevsim: avoid potential loop in nsim_dev_trap_report_work() (2024-02-02 11:00:38 -0800) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-02-02 > > > > > > > > > > for you to fetch changes up to 96d874780bf5b6352e45b4c07c247e37d50263c3: > > > > > > > > > > Bluetooth: qca: Fix triggering coredump implementation (2024-02-02 16:13:56 -0500) > > > > > > > > > > ---------------------------------------------------------------- > > > > > bluetooth pull request for net: > > > > > > > > A couple of commits have some issue in the tag area (spaces between > > > > Fixes and other tag): > > > > > > > > > > - btintel: Fix null ptr deref in btintel_read_version > > > > > - mgmt: Fix limited discoverable off timeout > > > > > - hci_qca: Set BDA quirk bit if fwnode exists in DT > > > > > > > > this one ^^^ > > > > > > > > > - hci_bcm4377: do not mark valid bd_addr as invalid > > > > > - hci_sync: Check the correct flag before starting a scan > > > > > - Enforce validation on max value of connection interval > > > > > > > > and this one ^^^ > > > > > > Ok, do you use any tools to capture these? checkpatch at least didn't > > > capture anything for me. > > > > We use the nipa tools: > > > > https://github.com/linux-netdev/nipa > > > > specifically: > > > > https://github.com/linux-netdev/nipa/blob/main/tests/patch/verify_fixes/verify_fixes.sh > > > > (it can run standalone) > > verify_fixes.sh HEAD^..HEAD > verify_fixes.sh: line 201: $DESC_FD: ambiguous redirect > > Not really sure where DESC_FD comes from, perhaps it needs to be set > in the environment, anyway can you send the output it is generating? I usually do: export DESC_FD=1 verify_fixes.sh HEAD^..HEAD Cheers, Paolo
On Tue, 6 Feb 2024 09:45:44 -0500 Luiz Augusto von Dentz wrote: > > > - hci_bcm4377: do not mark valid bd_addr as invalid > > > - hci_sync: Check the correct flag before starting a scan > > > - Enforce validation on max value of connection interval > > > > and this one ^^^ > > Ok, do you use any tools to capture these? checkpatch at least didn't > capture anything for me. You should use Greg's version directly: https://raw.githubusercontent.com/gregkh/gregkh-linux/master/work/scripts/verify_fixes.sh it has an ancestry check which should catch rebases.
The following changes since commit ba5e1272142d051dcc57ca1d3225ad8a089f9858: netdevsim: avoid potential loop in nsim_dev_trap_report_work() (2024-02-02 11:00:38 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-02-02 for you to fetch changes up to 96d874780bf5b6352e45b4c07c247e37d50263c3: Bluetooth: qca: Fix triggering coredump implementation (2024-02-02 16:13:56 -0500) ---------------------------------------------------------------- bluetooth pull request for net: - btintel: Fix null ptr deref in btintel_read_version - mgmt: Fix limited discoverable off timeout - hci_qca: Set BDA quirk bit if fwnode exists in DT - hci_bcm4377: do not mark valid bd_addr as invalid - hci_sync: Check the correct flag before starting a scan - Enforce validation on max value of connection interval - hci_sync: Fix accept_list when attempting to suspend - hci_event: Fix handling of HCI_EV_IO_CAPA_REQUEST - Avoid potential use-after-free in hci_error_reset - rfcomm: Fix null-ptr-deref in rfcomm_check_security - hci_event: Fix wrongly recorded wakeup BD_ADDR - qca: Fix wrong event type for patch config command - qca: Fix triggering coredump implementation ---------------------------------------------------------------- Edward Adam Davis (1): Bluetooth: btintel: Fix null ptr deref in btintel_read_version Frédéric Danis (1): Bluetooth: mgmt: Fix limited discoverable off timeout Janaki Ramaiah Thota (1): Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT Johan Hovold (1): Bluetooth: hci_bcm4377: do not mark valid bd_addr as invalid Jonas Dreßler (1): Bluetooth: hci_sync: Check the correct flag before starting a scan Kai-Heng Feng (1): Bluetooth: Enforce validation on max value of connection interval Luiz Augusto von Dentz (2): Bluetooth: hci_sync: Fix accept_list when attempting to suspend Bluetooth: hci_event: Fix handling of HCI_EV_IO_CAPA_REQUEST Ying Hsu (1): Bluetooth: Avoid potential use-after-free in hci_error_reset Yuxuan Hu (1): Bluetooth: rfcomm: Fix null-ptr-deref in rfcomm_check_security Zijun Hu (3): Bluetooth: hci_event: Fix wrongly recorded wakeup BD_ADDR Bluetooth: qca: Fix wrong event type for patch config command Bluetooth: qca: Fix triggering coredump implementation drivers/bluetooth/btintel.c | 2 +- drivers/bluetooth/btqca.c | 2 +- drivers/bluetooth/hci_bcm4377.c | 3 +-- drivers/bluetooth/hci_qca.c | 22 ++++++++++++++++------ net/bluetooth/hci_core.c | 7 ++++--- net/bluetooth/hci_event.c | 13 ++++++++++--- net/bluetooth/hci_sync.c | 7 +++++-- net/bluetooth/l2cap_core.c | 8 +++++++- net/bluetooth/mgmt.c | 4 +++- net/bluetooth/rfcomm/core.c | 2 +- 10 files changed, 49 insertions(+), 21 deletions(-)