| Message ID | 20240206165815.2420951-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/mlx5: remove redundant assignment to variable object_range | expand |
On Tue, Feb 06, 2024 at 04:58:15PM +0000, Colin Ian King wrote: > The variable object_range to log_header_modify_argument_granularity > is being assigned a value that is never read, the following statement > assigns object_range to the max of log_header_modify_argument_granularity > and DR_ICM_MODIFY_HDR_GRANULARITY_4K, so clearly the initial > assignment is redundant. Remove it. > > Cleans up clang-scan build warning: > drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c:42:2: warning: > Value stored to 'object_range' is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Thanks Colin, Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c index 01ed6442095d..c2218dc556c7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c @@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool) INIT_LIST_HEAD(&cur_list); - object_range = - pool->dmn->info.caps.log_header_modify_argument_granularity; - object_range = max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity, DR_ICM_MODIFY_HDR_GRANULARITY_4K);
The variable object_range to log_header_modify_argument_granularity is being assigned a value that is never read, the following statement assigns object_range to the max of log_header_modify_argument_granularity and DR_ICM_MODIFY_HDR_GRANULARITY_4K, so clearly the initial assignment is redundant. Remove it. Cleans up clang-scan build warning: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c:42:2: warning: Value stored to 'object_range' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_arg.c | 3 --- 1 file changed, 3 deletions(-)