| Message ID | 20240131071910.3950450-1-wenst@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] pinctrl: mediatek: Drop bogus slew rate register range for MT8186 | expand |
Il 31/01/24 08:19, Chen-Yu Tsai ha scritto: > The MT8186 does not support configuring pin slew rate. This is evident > from both the datasheet, and the fact that the driver points the slew > rate register range at the GPIO direction register range. > > Drop the bogus setting. > > Fixes: 8b483bda1e46 ("pinctrl: add pinctrl driver on mt8186") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Argh :-) Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Wed, Jan 31, 2024 at 8:19 AM Chen-Yu Tsai <wenst@chromium.org> wrote: > The MT8186 does not support configuring pin slew rate. This is evident > from both the datasheet, and the fact that the driver points the slew > rate register range at the GPIO direction register range. > > Drop the bogus setting. > > Fixes: 8b483bda1e46 ("pinctrl: add pinctrl driver on mt8186") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Patches applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8186.c b/drivers/pinctrl/mediatek/pinctrl-mt8186.c index 7be591591cce..dd19e74856a9 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mt8186.c +++ b/drivers/pinctrl/mediatek/pinctrl-mt8186.c @@ -1198,7 +1198,6 @@ static const struct mtk_pin_reg_calc mt8186_reg_cals[PINCTRL_PIN_REG_MAX] = { [PINCTRL_PIN_REG_DIR] = MTK_RANGE(mt8186_pin_dir_range), [PINCTRL_PIN_REG_DI] = MTK_RANGE(mt8186_pin_di_range), [PINCTRL_PIN_REG_DO] = MTK_RANGE(mt8186_pin_do_range), - [PINCTRL_PIN_REG_SR] = MTK_RANGE(mt8186_pin_dir_range), [PINCTRL_PIN_REG_SMT] = MTK_RANGE(mt8186_pin_smt_range), [PINCTRL_PIN_REG_IES] = MTK_RANGE(mt8186_pin_ies_range), [PINCTRL_PIN_REG_PU] = MTK_RANGE(mt8186_pin_pu_range),
The MT8186 does not support configuring pin slew rate. This is evident from both the datasheet, and the fact that the driver points the slew rate register range at the GPIO direction register range. Drop the bogus setting. Fixes: 8b483bda1e46 ("pinctrl: add pinctrl driver on mt8186") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- drivers/pinctrl/mediatek/pinctrl-mt8186.c | 1 - 1 file changed, 1 deletion(-)