Message ID | 20240206130017.7839-4-subhajit.ghosh@tweaklogic.com (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show |
Series | Support for Avago APDS9306 Ambient Light Sensor | expand |
On 06/02/2024 14:00, Subhajit Ghosh wrote: > Include irq.h and irq level macro in the example for readability > > this patch depends on patch: > "dt-bindings: iio: light: Add property vdd-supply" Please, don't write such useless dependencies. This is neither true nor useful. Best regards, Krzysztof
On 8/2/24 18:48, Krzysztof Kozlowski wrote: > On 06/02/2024 14:00, Subhajit Ghosh wrote: >> Include irq.h and irq level macro in the example for readability >> >> this patch depends on patch: >> "dt-bindings: iio: light: Add property vdd-supply" > > Please, don't write such useless dependencies. This is neither true nor > useful. Understood. > > > Best regards, > Krzysztof > Thank you for reviewing. Regards, Subhajit Ghosh
On Thu, 8 Feb 2024 21:23:09 +1030 Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> wrote: > On 8/2/24 18:48, Krzysztof Kozlowski wrote: > > On 06/02/2024 14:00, Subhajit Ghosh wrote: > >> Include irq.h and irq level macro in the example for readability > >> > >> this patch depends on patch: > >> "dt-bindings: iio: light: Add property vdd-supply" > > > > Please, don't write such useless dependencies. This is neither true nor > > useful. > Understood. Just for reference: If there were such a dependency (beyond noise in the diff) then there is still no need to state it when the patches are in the same series. Jonathan > > > > > > Best regards, > > Krzysztof > > > Thank you for reviewing. > Regards, > Subhajit Ghosh >
diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml index a328c8a1daef..e07a074f6acf 100644 --- a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml @@ -35,6 +35,8 @@ required: examples: - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { #address-cells = <1>; #size-cells = <0>; @@ -43,7 +45,7 @@ examples: compatible = "avago,apds9300"; reg = <0x39>; interrupt-parent = <&gpio2>; - interrupts = <29 8>; + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; vdd-supply = <®ulator_3v3>; }; };
Include irq.h and irq level macro in the example for readability this patch depends on patch: "dt-bindings: iio: light: Add property vdd-supply" Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> --- v5 -> v6: - Separate commit for individual change as per below review: Link: https://lore.kernel.org/all/20240121153655.5f734180@jic23-huawei/ --- .../devicetree/bindings/iio/light/avago,apds9300.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)