| Message ID | 20240207111411.115040-5-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mips: do not list individual devices from configs/ | expand |
On Wed, 7 Feb 2024, Paolo Bonzini wrote: > ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol: > instead it requires one. Among its users, VT82C686 is the only one that > is a PCI-ISA bridge and does not already select ISA_BUS. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > hw/isa/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig > index 7884179d08b..5df3c09cd51 100644 > --- a/hw/isa/Kconfig > +++ b/hw/isa/Kconfig > @@ -15,7 +15,7 @@ config I82378 > > config ISA_SUPERIO > bool > - select ISA_BUS > + depends on ISA_BUS > select PCKBD > select PARALLEL > select SERIAL_ISA > @@ -47,6 +47,7 @@ config PIIX > > config VT82C686 > bool > + select ISA_BUS > select ISA_SUPERIO > select ACPI > select ACPI_SMBUS >
On 7/2/24 12:14, Paolo Bonzini wrote: > ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol: > instead it requires one. Among its users, VT82C686 is the only one that > is a PCI-ISA bridge and does not already select ISA_BUS. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > hw/isa/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Am 7. Februar 2024 11:14:06 UTC schrieb Paolo Bonzini <pbonzini@redhat.com>: >ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol: >instead it requires one. Among its users, VT82C686 is the only one that >is a PCI-ISA bridge and does not already select ISA_BUS. > >Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Bernhard Beschow <shentey@gmail.com> >--- > hw/isa/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig >index 7884179d08b..5df3c09cd51 100644 >--- a/hw/isa/Kconfig >+++ b/hw/isa/Kconfig >@@ -15,7 +15,7 @@ config I82378 > > config ISA_SUPERIO > bool >- select ISA_BUS >+ depends on ISA_BUS > select PCKBD > select PARALLEL > select SERIAL_ISA >@@ -47,6 +47,7 @@ config PIIX > > config VT82C686 > bool >+ select ISA_BUS > select ISA_SUPERIO > select ACPI > select ACPI_SMBUS
diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 7884179d08b..5df3c09cd51 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -15,7 +15,7 @@ config I82378 config ISA_SUPERIO bool - select ISA_BUS + depends on ISA_BUS select PCKBD select PARALLEL select SERIAL_ISA @@ -47,6 +47,7 @@ config PIIX config VT82C686 bool + select ISA_BUS select ISA_SUPERIO select ACPI select ACPI_SMBUS
ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol: instead it requires one. Among its users, VT82C686 is the only one that is a PCI-ISA bridge and does not already select ISA_BUS. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/isa/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)