| Message ID | 20240209015817.14627-8-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mfd: tmio: simplify header and move to platform_data | expand |
On Fri, 09 Feb 2024, Wolfram Sang wrote: > The MFD parts of the TMIO have been removed by Arnd, so that only the > SD/MMC related functionality is left. Remove the outdated remains in the > public header file and then move it to platform_data as the data is now > specific for the SD/MMC part. > > Based on 6.8-rc3, build bot is happy. Branch is here: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tmio-simplification > > I'd suggest this goes via the MFD tree, so the series would need acks > from the MMC and SH maintainers. Is that okay with everyone? > > All the best! > > Wolfram Could you please change all of the subject lines with "mfd" in them i.e. all of the commits which touch include/linux/mfd and ensure the description starts with an upper case char? I like all commits that touch drivers/mfd and include/linux/mfd to have the same formatting structure. Thanks. > Wolfram Sang (6): > mfd: tmio: remove obsolete platform_data > mfd: tmio: remove obsolete io accessors > mmc: tmio/sdhi: fix includes > mfd: tmio: update include files > mfd: tmio: sanitize comments > mfd: tmio: move header to platform_data > > MAINTAINERS | 2 +- > arch/sh/boards/board-sh7757lcr.c | 2 +- > arch/sh/boards/mach-ap325rxa/setup.c | 2 +- > arch/sh/boards/mach-ecovec24/setup.c | 2 +- > arch/sh/boards/mach-kfr2r09/setup.c | 2 +- > arch/sh/boards/mach-migor/setup.c | 2 +- > arch/sh/boards/mach-se/7724/setup.c | 2 +- > drivers/mmc/host/renesas_sdhi_core.c | 2 +- > drivers/mmc/host/renesas_sdhi_internal_dmac.c | 5 +- > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 5 +- > drivers/mmc/host/tmio_mmc_core.c | 3 +- > drivers/mmc/host/uniphier-sd.c | 2 +- > include/linux/mfd/tmio.h | 133 ------------------ > include/linux/platform_data/tmio.h | 64 +++++++++ > 14 files changed, 81 insertions(+), 147 deletions(-) > delete mode 100644 include/linux/mfd/tmio.h > create mode 100644 include/linux/platform_data/tmio.h > > -- > 2.43.0 >
On Fri, Feb 09, 2024 at 07:58:39AM +0000, Lee Jones wrote: > On Fri, 09 Feb 2024, Wolfram Sang wrote: > > > The MFD parts of the TMIO have been removed by Arnd, so that only the > > SD/MMC related functionality is left. Remove the outdated remains in the > > public header file and then move it to platform_data as the data is now > > specific for the SD/MMC part. > > > > Based on 6.8-rc3, build bot is happy. Branch is here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tmio-simplification > > > > I'd suggest this goes via the MFD tree, so the series would need acks > > from the MMC and SH maintainers. Is that okay with everyone? > > > > All the best! > > > > Wolfram > > Could you please change all of the subject lines with "mfd" in them > i.e. all of the commits which touch include/linux/mfd and ensure the > description starts with an upper case char? > > I like all commits that touch drivers/mfd and include/linux/mfd to have > the same formatting structure. Sure, I'll just wait one day for other review comments. Thanks for your review!
On Fri, 9 Feb 2024 at 02:59, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > The MFD parts of the TMIO have been removed by Arnd, so that only the > SD/MMC related functionality is left. Remove the outdated remains in the > public header file and then move it to platform_data as the data is now > specific for the SD/MMC part. > > Based on 6.8-rc3, build bot is happy. Branch is here: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tmio-simplification > > I'd suggest this goes via the MFD tree, so the series would need acks > from the MMC and SH maintainers. Is that okay with everyone? Wouldn't it be better to funnel this via the mmc tree? In that way, we can easily avoid conflicts with additional renesas-mmc driver changes that we have in pipe. Or perhaps there are other changes that make the mfd tree preferred? Kind regards Uffe > > All the best! > > Wolfram > > > Wolfram Sang (6): > mfd: tmio: remove obsolete platform_data > mfd: tmio: remove obsolete io accessors > mmc: tmio/sdhi: fix includes > mfd: tmio: update include files > mfd: tmio: sanitize comments > mfd: tmio: move header to platform_data > > MAINTAINERS | 2 +- > arch/sh/boards/board-sh7757lcr.c | 2 +- > arch/sh/boards/mach-ap325rxa/setup.c | 2 +- > arch/sh/boards/mach-ecovec24/setup.c | 2 +- > arch/sh/boards/mach-kfr2r09/setup.c | 2 +- > arch/sh/boards/mach-migor/setup.c | 2 +- > arch/sh/boards/mach-se/7724/setup.c | 2 +- > drivers/mmc/host/renesas_sdhi_core.c | 2 +- > drivers/mmc/host/renesas_sdhi_internal_dmac.c | 5 +- > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 5 +- > drivers/mmc/host/tmio_mmc_core.c | 3 +- > drivers/mmc/host/uniphier-sd.c | 2 +- > include/linux/mfd/tmio.h | 133 ------------------ > include/linux/platform_data/tmio.h | 64 +++++++++ > 14 files changed, 81 insertions(+), 147 deletions(-) > delete mode 100644 include/linux/mfd/tmio.h > create mode 100644 include/linux/platform_data/tmio.h > > -- > 2.43.0 > >
On Fri, 09 Feb 2024, Ulf Hansson wrote: > On Fri, 9 Feb 2024 at 02:59, Wolfram Sang > <wsa+renesas@sang-engineering.com> wrote: > > > > The MFD parts of the TMIO have been removed by Arnd, so that only the > > SD/MMC related functionality is left. Remove the outdated remains in the > > public header file and then move it to platform_data as the data is now > > specific for the SD/MMC part. > > > > Based on 6.8-rc3, build bot is happy. Branch is here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tmio-simplification > > > > I'd suggest this goes via the MFD tree, so the series would need acks > > from the MMC and SH maintainers. Is that okay with everyone? > > Wouldn't it be better to funnel this via the mmc tree? In that way, we > can easily avoid conflicts with additional renesas-mmc driver changes > that we have in pipe. You could say the same about changes SH, MFD and Platform Data have in the pipe. > Or perhaps there are other changes that make the mfd tree preferred? MFD is usually preferred since the parent device usually lives there and we are well accustomed to merging multi-subsystem related sets. It doesn't really matter how this is merged. The only stipulation is that whoever applies the set does so on a succinct, immutable, tagged branch and sends out a pull-request for everyone else to pull from. If you want to do that, there are no complains from me. > > All the best! > > > > Wolfram > > > > > > Wolfram Sang (6): > > mfd: tmio: remove obsolete platform_data > > mfd: tmio: remove obsolete io accessors > > mmc: tmio/sdhi: fix includes > > mfd: tmio: update include files > > mfd: tmio: sanitize comments > > mfd: tmio: move header to platform_data > > > > MAINTAINERS | 2 +- > > arch/sh/boards/board-sh7757lcr.c | 2 +- > > arch/sh/boards/mach-ap325rxa/setup.c | 2 +- > > arch/sh/boards/mach-ecovec24/setup.c | 2 +- > > arch/sh/boards/mach-kfr2r09/setup.c | 2 +- > > arch/sh/boards/mach-migor/setup.c | 2 +- > > arch/sh/boards/mach-se/7724/setup.c | 2 +- > > drivers/mmc/host/renesas_sdhi_core.c | 2 +- > > drivers/mmc/host/renesas_sdhi_internal_dmac.c | 5 +- > > drivers/mmc/host/renesas_sdhi_sys_dmac.c | 5 +- > > drivers/mmc/host/tmio_mmc_core.c | 3 +- > > drivers/mmc/host/uniphier-sd.c | 2 +- > > include/linux/mfd/tmio.h | 133 ------------------ > > include/linux/platform_data/tmio.h | 64 +++++++++ > > 14 files changed, 81 insertions(+), 147 deletions(-) > > delete mode 100644 include/linux/mfd/tmio.h > > create mode 100644 include/linux/platform_data/tmio.h > > > > -- > > 2.43.0 > > > >
On Fri, 9 Feb 2024 at 14:28, Lee Jones <lee@kernel.org> wrote: > > On Fri, 09 Feb 2024, Ulf Hansson wrote: > > > On Fri, 9 Feb 2024 at 02:59, Wolfram Sang > > <wsa+renesas@sang-engineering.com> wrote: > > > > > > The MFD parts of the TMIO have been removed by Arnd, so that only the > > > SD/MMC related functionality is left. Remove the outdated remains in the > > > public header file and then move it to platform_data as the data is now > > > specific for the SD/MMC part. > > > > > > Based on 6.8-rc3, build bot is happy. Branch is here: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tmio-simplification > > > > > > I'd suggest this goes via the MFD tree, so the series would need acks > > > from the MMC and SH maintainers. Is that okay with everyone? > > > > Wouldn't it be better to funnel this via the mmc tree? In that way, we > > can easily avoid conflicts with additional renesas-mmc driver changes > > that we have in pipe. > > You could say the same about changes SH, MFD and Platform Data have in > the pipe. > > > Or perhaps there are other changes that make the mfd tree preferred? > > MFD is usually preferred since the parent device usually lives there and > we are well accustomed to merging multi-subsystem related sets. > > It doesn't really matter how this is merged. The only stipulation is > that whoever applies the set does so on a succinct, immutable, tagged > branch and sends out a pull-request for everyone else to pull from. You are right. Although, in this particular case I thought it could make better sense to use the mmc tree, because 1) we are only removing a header file from mfd and 2) I know we have other renesas-mmc changes in the pipe for the next release. The point is, I wanted us to avoid the need for using an immutable branch. But nevermind. > > If you want to do that, there are no complains from me. Well, it sounds like we may need the flexibility with the immutable branch, so I suggest we do the usual thing with the mfd tree. Please add my ack for the mmc related changes. [...] Kind regards Uffe
Hi Lee, Ulf,
> Please add my ack for the mmc related changes.
I prepared v2 of the series: rebased to rc4, acks added, capitalized
first letter... waiting for buildbot now before resending.
Thanks,
Wolfram