dt-bindings: net: realtek: Use proper node names

Commit Message

Linus Walleij Feb. 8, 2024, 10:40 p.m. UTC

Replace:
- switch with ethernet-switch
- ports with ethernet-ports
- port with ethernet-port

Signed-off-by: Linus Walleij <[e-mail]>
---
 .../devicetree/bindings/net/dsa/realtek.yaml       | 46 +++++++++++-----------
 1 file changed, 23 insertions(+), 23 deletions(-)


---
base-commit: 618b16bbf071a7e8d9601f7ba259a00a169a3937
change-id: 20240208-realtek-bindings-fixup-1d8ebaf19dba

Best regards,

Comments

Krzysztof Kozlowski Feb. 9, 2024, 7:47 a.m. UTC | #1

On 08/02/2024 23:40, Linus Walleij wrote:
> Replace:
> - switch with ethernet-switch
> - ports with ethernet-ports
> - port with ethernet-port

Would be nice to see answer "why" (because it is preferred naming
style), because what is visible from the diff.

Reviewed-by: Krzysztof Kozlowski <[e-mail]>

Best regards,
Krzysztof

Linus Walleij Feb. 9, 2024, 1:30 p.m. UTC | #2

On Fri, Feb 9, 2024 at 8:47 AM Krzysztof Kozlowski
<[e-mail]> wrote:
> On 08/02/2024 23:40, Linus Walleij wrote:

> > Replace:
> > - switch with ethernet-switch
> > - ports with ethernet-ports
> > - port with ethernet-port
>
> Would be nice to see answer "why" (because it is preferred naming
> style), because what is visible from the diff.

I guess we eventually want to get to a place where we fix all DTS files
so that we can simply disallow switch/port/ports without ethernet-* prefix
so they become easier to read (you immediately know which kind of
switch/port etc it is).

At least that is my "why", also yours?

I can add this to the commit message.

Yours,
Linus Walleij

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
index cce692f57b08..4971dac6a233 100644
--- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
@@ -145,7 +145,7 @@  examples:
     #include <dt-bindings/interrupt-controller/irq.h>
 
     platform {
-            switch {
+            ethernet-switch {
                     compatible = "realtek,rtl8366rb";
                     /* 22 = MDIO (has input reads), 21 = MDC (clock, output only) */
                     mdc-gpios = <&gpio0 21 GPIO_ACTIVE_HIGH>;
@@ -161,35 +161,35 @@  examples:
                             #interrupt-cells = <1>;
                     };
 
-                    ports {
+                    ethernet-ports {
                             #address-cells = <1>;
                             #size-cells = <0>;
-                            port@0 {
+                            ethernet-port@0 {
                                     reg = <0>;
                                     label = "lan0";
                                     phy-handle = <&phy0>;
                             };
-                            port@1 {
+                            ethernet-port@1 {
                                     reg = <1>;
                                     label = "lan1";
                                     phy-handle = <&phy1>;
                             };
-                            port@2 {
+                            ethernet-port@2 {
                                     reg = <2>;
                                     label = "lan2";
                                     phy-handle = <&phy2>;
                             };
-                            port@3 {
+                            ethernet-port@3 {
                                     reg = <3>;
                                     label = "lan3";
                                     phy-handle = <&phy3>;
                             };
-                            port@4 {
+                            ethernet-port@4 {
                                     reg = <4>;
                                     label = "wan";
                                     phy-handle = <&phy4>;
                             };
-                            port@5 {
+                            ethernet-port@5 {
                                     reg = <5>;
                                     ethernet = <&gmac0>;
                                     phy-mode = "rgmii";
@@ -239,7 +239,7 @@  examples:
     #include <dt-bindings/interrupt-controller/irq.h>
 
     platform {
-            switch {
+            ethernet-switch {
                     compatible = "realtek,rtl8365mb";
                     mdc-gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>;
                     mdio-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
@@ -253,30 +253,30 @@  examples:
                             #interrupt-cells = <1>;
                     };
 
-                    ports {
+                    ethernet-ports {
                             #address-cells = <1>;
                             #size-cells = <0>;
-                            port@0 {
+                            ethernet-port@0 {
                                     reg = <0>;
                                     label = "swp0";
                                     phy-handle = <&ethphy0>;
                             };
-                            port@1 {
+                            ethernet-port@1 {
                                     reg = <1>;
                                     label = "swp1";
                                     phy-handle = <&ethphy1>;
                             };
-                            port@2 {
+                            ethernet-port@2 {
                                     reg = <2>;
                                     label = "swp2";
                                     phy-handle = <&ethphy2>;
                             };
-                            port@3 {
+                            ethernet-port@3 {
                                     reg = <3>;
                                     label = "swp3";
                                     phy-handle = <&ethphy3>;
                             };
-                            port@6 {
+                            ethernet-port@6 {
                                     reg = <6>;
                                     ethernet = <&fec1>;
                                     phy-mode = "rgmii";
@@ -328,7 +328,7 @@  examples:
             #address-cells = <1>;
             #size-cells = <0>;
 
-            switch@29 {
+            ethernet-switch@29 {
                     compatible = "realtek,rtl8365mb";
                     reg = <29>;
 
@@ -342,36 +342,36 @@  examples:
                             #interrupt-cells = <1>;
                     };
 
-                    ports {
+                    ethernet-ports {
                             #address-cells = <1>;
                             #size-cells = <0>;
 
-                            port@0 {
+                            ethernet-port@0 {
                                     reg = <0>;
                                     label = "lan4";
                             };
 
-                            port@1 {
+                            ethernet-port@1 {
                                     reg = <1>;
                                     label = "lan3";
                             };
 
-                            port@2 {
+                            ethernet-port@2 {
                                     reg = <2>;
                                     label = "lan2";
                             };
 
-                            port@3 {
+                            ethernet-port@3 {
                                     reg = <3>;
                                     label = "lan1";
                             };
 
-                            port@4 {
+                            ethernet-port@4 {
                                     reg = <4>;
                                     label = "wan";
                             };
 
-                            port@7 {
+                            ethernet-port@7 {
                                     reg = <7>;
                                     ethernet = <&ethernet>;
                                     phy-mode = "rgmii";