| Message ID | 20240206164814.46984-1-n.zhandarovich@fintech.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/radeon/ni: Fix wrong firmware size logging in ni_init_microcode() | expand |
Applied. Thanks! On Tue, Feb 6, 2024 at 11:48 AM Nikita Zhandarovich <n.zhandarovich@fintech.ru> wrote: > > Clean up a typo in pr_err() erroneously printing NI MC 'rdev->mc_fw->size' > during SMC firmware load. Log 'rdev->smc_fw->size' instead. > > Found by Linux Verification Center (linuxtesting.org) with static > analysis tool SVACE. > > Fixes: 6596afd48af4 ("drm/radeon/kms: add dpm support for btc (v3)") > Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru> > --- > drivers/gpu/drm/radeon/ni.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c > index 927e5f42e97d..3e48cbb522a1 100644 > --- a/drivers/gpu/drm/radeon/ni.c > +++ b/drivers/gpu/drm/radeon/ni.c > @@ -813,7 +813,7 @@ int ni_init_microcode(struct radeon_device *rdev) > err = 0; > } else if (rdev->smc_fw->size != smc_req_size) { > pr_err("ni_mc: Bogus length %zu in firmware \"%s\"\n", > - rdev->mc_fw->size, fw_name); > + rdev->smc_fw->size, fw_name); > err = -EINVAL; > } > } > -- > 2.25.1 >
diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c index 927e5f42e97d..3e48cbb522a1 100644 --- a/drivers/gpu/drm/radeon/ni.c +++ b/drivers/gpu/drm/radeon/ni.c @@ -813,7 +813,7 @@ int ni_init_microcode(struct radeon_device *rdev) err = 0; } else if (rdev->smc_fw->size != smc_req_size) { pr_err("ni_mc: Bogus length %zu in firmware \"%s\"\n", - rdev->mc_fw->size, fw_name); + rdev->smc_fw->size, fw_name); err = -EINVAL; } }
Clean up a typo in pr_err() erroneously printing NI MC 'rdev->mc_fw->size' during SMC firmware load. Log 'rdev->smc_fw->size' instead. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 6596afd48af4 ("drm/radeon/kms: add dpm support for btc (v3)") Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru> --- drivers/gpu/drm/radeon/ni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)