| Message ID | 20240209160829.3930396-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] drm/i915/gvt: remove redundant assignment to pointer map | expand |
On Fri, 9 Feb 2024 16:08:29 +0000 Colin Ian King <colin.i.king@gmail.com> wrote: > The pointer map is being initialized with a value that is never > read, it is being re-assigned later on in a for-loop. The > initialization is redundant and can be removed. > > Cleans up clang scan build warning: > drivers/gpu/drm/i915/gvt/interrupt.c:346:28: warning: Value stored to > 'map' during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/gpu/drm/i915/gvt/interrupt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c > b/drivers/gpu/drm/i915/gvt/interrupt.c index > c8e7dfc9f791..8c8e37f50a45 100644 --- > a/drivers/gpu/drm/i915/gvt/interrupt.c +++ > b/drivers/gpu/drm/i915/gvt/interrupt.c @@ -343,7 +343,7 @@ static > void update_upstream_irq(struct intel_vgpu *vgpu, { > struct drm_i915_private *i915 = vgpu->gvt->gt->i915; > struct intel_gvt_irq *irq = &vgpu->gvt->irq; > - struct intel_gvt_irq_map *map = irq->irq_map; > + struct intel_gvt_irq_map *map; > struct intel_gvt_irq_info *up_irq_info = NULL; > u32 set_bits = 0; > u32 clear_bits = 0; Thanks for the patch! Reviewed-by: Zhi Wang <zhi.wang.linux@gmail.com>
diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/gvt/interrupt.c index c8e7dfc9f791..8c8e37f50a45 100644 --- a/drivers/gpu/drm/i915/gvt/interrupt.c +++ b/drivers/gpu/drm/i915/gvt/interrupt.c @@ -343,7 +343,7 @@ static void update_upstream_irq(struct intel_vgpu *vgpu, { struct drm_i915_private *i915 = vgpu->gvt->gt->i915; struct intel_gvt_irq *irq = &vgpu->gvt->irq; - struct intel_gvt_irq_map *map = irq->irq_map; + struct intel_gvt_irq_map *map; struct intel_gvt_irq_info *up_irq_info = NULL; u32 set_bits = 0; u32 clear_bits = 0;
The pointer map is being initialized with a value that is never read, it is being re-assigned later on in a for-loop. The initialization is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/drm/i915/gvt/interrupt.c:346:28: warning: Value stored to 'map' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/gpu/drm/i915/gvt/interrupt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)