| Message ID | 20240213112122.404045-7-leitao@debian.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Fix MODULE_DESCRIPTION() for net (p6) | expand |
On Tue, Feb 13, 2024 at 03:21:21AM -0800, Breno Leitao wrote: > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to the PHY MDIO helpers. > > Signed-off-by: Breno Leitao <leitao@debian.org> > --- > drivers/net/phy/mdio_devres.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/mdio_devres.c b/drivers/net/phy/mdio_devres.c > index 69b829e6ab35..8921fa22bdbd 100644 > --- a/drivers/net/phy/mdio_devres.c > +++ b/drivers/net/phy/mdio_devres.c > @@ -131,4 +131,5 @@ int __devm_of_mdiobus_register(struct device *dev, struct mii_bus *mdio, > EXPORT_SYMBOL(__devm_of_mdiobus_register); > #endif /* CONFIG_OF_MDIO */ > > +MODULE_DESCRIPTION("Network PHY MDIO devres helpers"); "Network MDIO bus devres helpers" There is nothing PHY related in here, its all mdio bus. Andrew
On Tue, Feb 13, 2024 at 02:19:39PM +0100, Andrew Lunn wrote: > On Tue, Feb 13, 2024 at 03:21:21AM -0800, Breno Leitao wrote: > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > > Add descriptions to the PHY MDIO helpers. > > > > Signed-off-by: Breno Leitao <leitao@debian.org> > > --- > > drivers/net/phy/mdio_devres.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/phy/mdio_devres.c b/drivers/net/phy/mdio_devres.c > > index 69b829e6ab35..8921fa22bdbd 100644 > > --- a/drivers/net/phy/mdio_devres.c > > +++ b/drivers/net/phy/mdio_devres.c > > @@ -131,4 +131,5 @@ int __devm_of_mdiobus_register(struct device *dev, struct mii_bus *mdio, > > EXPORT_SYMBOL(__devm_of_mdiobus_register); > > #endif /* CONFIG_OF_MDIO */ > > > > +MODULE_DESCRIPTION("Network PHY MDIO devres helpers"); > > "Network MDIO bus devres helpers" > > There is nothing PHY related in here, its all mdio bus. Thanks. I will update!
diff --git a/drivers/net/phy/mdio_devres.c b/drivers/net/phy/mdio_devres.c index 69b829e6ab35..8921fa22bdbd 100644 --- a/drivers/net/phy/mdio_devres.c +++ b/drivers/net/phy/mdio_devres.c @@ -131,4 +131,5 @@ int __devm_of_mdiobus_register(struct device *dev, struct mii_bus *mdio, EXPORT_SYMBOL(__devm_of_mdiobus_register); #endif /* CONFIG_OF_MDIO */ +MODULE_DESCRIPTION("Network PHY MDIO devres helpers"); MODULE_LICENSE("GPL");
W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to the PHY MDIO helpers. Signed-off-by: Breno Leitao <leitao@debian.org> --- drivers/net/phy/mdio_devres.c | 1 + 1 file changed, 1 insertion(+)