| Message ID | 20240130095656.3712469-4-wenst@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: mediatek: mtk-socinfo: Fixes and cleanup | expand |
Il 30/01/24 10:56, Chen-Yu Tsai ha scritto: > The MT8183 has not one but two efuse devices. The static name and ID > causes the second efuse device to fail to probe, due to duplicate sysfs > entries. > > With the rework of the mtk-socinfo driver, lookup by name is no longer > necessary. The custom name can simply be dropped. > > Fixes: 4e6102d60d88 ("nvmem: mtk-efuse: Register MediaTek socinfo driver from efuse") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Tue, Jan 30, 2024 at 05:56:53PM +0800, Chen-Yu Tsai wrote: > The MT8183 has not one but two efuse devices. The static name and ID > causes the second efuse device to fail to probe, due to duplicate sysfs > entries. > > With the rework of the mtk-socinfo driver, lookup by name is no longer > necessary. The custom name can simply be dropped. > > Fixes: 4e6102d60d88 ("nvmem: mtk-efuse: Register MediaTek socinfo driver from efuse") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> This does fix the efuse (and display) probe issue on MT8183. FYI I've sent a regression report for it at https://lore.kernel.org/all/47cdeac1-121d-4b1a-a3ac-e2affc7a2fc3@notapiano Thanks, Nícolas
On 30/01/2024 09:56, Chen-Yu Tsai wrote: > The MT8183 has not one but two efuse devices. The static name and ID > causes the second efuse device to fail to probe, due to duplicate sysfs > entries. have you considered using NVMEM_DEVID_AUTO? --srini > > With the rework of the mtk-socinfo driver, lookup by name is no longer > necessary. The custom name can simply be dropped. > > Fixes: 4e6102d60d88 ("nvmem: mtk-efuse: Register MediaTek socinfo driver from efuse") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > drivers/nvmem/mtk-efuse.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c > index f5bebcecf9bd..9caf04667341 100644 > --- a/drivers/nvmem/mtk-efuse.c > +++ b/drivers/nvmem/mtk-efuse.c > @@ -86,7 +86,6 @@ static int mtk_efuse_probe(struct platform_device *pdev) > econfig.size = resource_size(res); > econfig.priv = priv; > econfig.dev = dev; > - econfig.name = "mtk-efuse"; > if (pdata->uses_post_processing) > econfig.fixup_dt_cell_info = &mtk_efuse_fixup_dt_cell_info; > nvmem = devm_nvmem_register(dev, &econfig);
On Tue, Feb 13, 2024 at 9:07 PM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > > > > On 30/01/2024 09:56, Chen-Yu Tsai wrote: > > The MT8183 has not one but two efuse devices. The static name and ID > > causes the second efuse device to fail to probe, due to duplicate sysfs > > entries. > > have you considered using NVMEM_DEVID_AUTO? Yes, that was considered and what is actually implemented downstream. However, since the reason for using a custom name no longer exists, it seems simpler to just revert to the previous behavior, which is to let the nvmem core deal with naming. ChenYu > --srini > > > > With the rework of the mtk-socinfo driver, lookup by name is no longer > > necessary. The custom name can simply be dropped. > > > > Fixes: 4e6102d60d88 ("nvmem: mtk-efuse: Register MediaTek socinfo driver from efuse") > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > --- > > drivers/nvmem/mtk-efuse.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c > > index f5bebcecf9bd..9caf04667341 100644 > > --- a/drivers/nvmem/mtk-efuse.c > > +++ b/drivers/nvmem/mtk-efuse.c > > @@ -86,7 +86,6 @@ static int mtk_efuse_probe(struct platform_device *pdev) > > econfig.size = resource_size(res); > > econfig.priv = priv; > > econfig.dev = dev; > > - econfig.name = "mtk-efuse"; > > if (pdata->uses_post_processing) > > econfig.fixup_dt_cell_info = &mtk_efuse_fixup_dt_cell_info; > > nvmem = devm_nvmem_register(dev, &econfig);
diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index f5bebcecf9bd..9caf04667341 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -86,7 +86,6 @@ static int mtk_efuse_probe(struct platform_device *pdev) econfig.size = resource_size(res); econfig.priv = priv; econfig.dev = dev; - econfig.name = "mtk-efuse"; if (pdata->uses_post_processing) econfig.fixup_dt_cell_info = &mtk_efuse_fixup_dt_cell_info; nvmem = devm_nvmem_register(dev, &econfig);
The MT8183 has not one but two efuse devices. The static name and ID causes the second efuse device to fail to probe, due to duplicate sysfs entries. With the rework of the mtk-socinfo driver, lookup by name is no longer necessary. The custom name can simply be dropped. Fixes: 4e6102d60d88 ("nvmem: mtk-efuse: Register MediaTek socinfo driver from efuse") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- drivers/nvmem/mtk-efuse.c | 1 - 1 file changed, 1 deletion(-)