diff mbox series

[v2] mdadm: fix update=resync regression

Message ID 20240209130216.19055-1-mariusz.tkaczyk@linux.intel.com (mailing list archive)
State Accepted
Headers show
Series [v2] mdadm: fix update=resync regression | expand

Commit Message

Mariusz Tkaczyk Feb. 9, 2024, 1:02 p.m. UTC
mdadm --assemble --update=resync started failing  with the error
"mdadm: --update=resync not understood for 1.x metadata".

It is a regression. Add omitted branch to fix error.

Resubmitted, original author is not responding.
https://lore.kernel.org/linux-raid/ZZqJlCToUS3Qrl4J@bianca.dpss.psy.unipd.it/

Fixes: 7e8daba8b793 ("super1: refactor the code for enum")
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
---
 super1.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Mariusz Tkaczyk Feb. 13, 2024, 3:18 p.m. UTC | #1
On Fri,  9 Feb 2024 14:02:16 +0100
Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:

> mdadm --assemble --update=resync started failing  with the error
> "mdadm: --update=resync not understood for 1.x metadata".
> 
> It is a regression. Add omitted branch to fix error.
> 
> Resubmitted, original author is not responding.
> https://lore.kernel.org/linux-raid/ZZqJlCToUS3Qrl4J@bianca.dpss.psy.unipd.it/
> 
> Fixes: 7e8daba8b793 ("super1: refactor the code for enum")
> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
> ---

No comments, Applied! 

Thanks,
Mariusz
diff mbox series

Patch

diff --git a/super1.c b/super1.c
index 5fd2228efbd6..871d19f0398c 100644
--- a/super1.c
+++ b/super1.c
@@ -1348,6 +1348,10 @@  static int update_super1(struct supertype *st, struct mdinfo *info,
 			__cpu_to_le16(info->disk.raid_disk);
 		break;
 	}
+	case UOPT_RESYNC:
+		/* make sure resync happens */
+		sb->resync_offset = 0;
+		break;
 	case UOPT_UUID:
 		copy_uuid(sb->set_uuid, info->uuid, super1.swapuuid);