| Message ID | 20240213220331.239031-4-paweldembicki@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: vsc73xx: Make vsc73xx usable | expand |
On Tue, Feb 13, 2024 at 11:05 PM Pawel Dembicki <paweldembicki@gmail.com> wrote: > It's preparation for future use. At this moment, the RGMII port is used > only for a connection to the MAC interface, but in the future, someone > could connect a PHY to it. Using the "phy_interface_mode_is_rgmii" macro > allows for the proper recognition of all RGMII modes. > > Suggested-by: Russell King <linux@armlinux.org.uk> > Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On 2/13/24 14:03, Pawel Dembicki wrote: > It's preparation for future use. At this moment, the RGMII port is used > only for a connection to the MAC interface, but in the future, someone > could connect a PHY to it. Using the "phy_interface_mode_is_rgmii" macro > allows for the proper recognition of all RGMII modes. > > Suggested-by: Russell King <linux@armlinux.org.uk> > Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On Tue, Feb 13, 2024 at 11:03:16PM +0100, Pawel Dembicki wrote: > It's preparation for future use. At this moment, the RGMII port is used > only for a connection to the MAC interface, but in the future, someone > could connect a PHY to it. Using the "phy_interface_mode_is_rgmii" macro > allows for the proper recognition of all RGMII modes. > > Suggested-by: Russell King <linux@armlinux.org.uk> > Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vitesse-vsc73xx-core.c index 70dd3f96dafb..5b54823b2caa 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-core.c +++ b/drivers/net/dsa/vitesse-vsc73xx-core.c @@ -833,7 +833,7 @@ static void vsc73xx_phylink_mac_link_up(struct dsa_switch *ds, int port, else val = VSC73XX_MAC_CFG_TX_IPG_100_10M; - if (interface == PHY_INTERFACE_MODE_RGMII) + if (phy_interface_mode_is_rgmii(interface)) val |= VSC73XX_MAC_CFG_CLK_SEL_1000M; else val |= VSC73XX_MAC_CFG_CLK_SEL_EXT;
It's preparation for future use. At this moment, the RGMII port is used only for a connection to the MAC interface, but in the future, someone could connect a PHY to it. Using the "phy_interface_mode_is_rgmii" macro allows for the proper recognition of all RGMII modes. Suggested-by: Russell King <linux@armlinux.org.uk> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com> --- v4: - introduced patch drivers/net/dsa/vitesse-vsc73xx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)