| Message ID | 20240213161502.2297048-1-kheib@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e8d8acad5a85b5ee3e9ec502357dbd8ac27b9015 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ena: Remove unlikely() from IS_ERR() condition | expand |
> -----Original Message----- > From: Kamal Heib <kheib@redhat.com> > Sent: Tuesday, February 13, 2024 6:15 PM > To: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>; Jakub > Kicinski <kuba@kernel.org> > Cc: Agroskin, Shay <shayagr@amazon.com>; Arinzon, David > <darinzon@amazon.com>; Kamal Heib <kheib@redhat.com> > Subject: [EXTERNAL] [PATCH net-next] net: ena: Remove unlikely() from > IS_ERR() condition > > > > IS_ERR() is already using unlikely internally. > > Signed-off-by: Kamal Heib <kheib@redhat.com> > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c > b/drivers/net/ethernet/amazon/ena/ena_netdev.c > index 03be2c008c4d..10e70d869cce 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c > +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c > @@ -545,7 +545,7 @@ static int ena_alloc_rx_buffer(struct ena_ring > *rx_ring, > > /* We handle DMA here */ > page = ena_alloc_map_page(rx_ring, &dma); > - if (unlikely(IS_ERR(page))) > + if (IS_ERR(page)) > return PTR_ERR(page); > > netif_dbg(rx_ring->adapter, rx_status, rx_ring->netdev, > -- > 2.43.0 > Thanks for submitting this patch. Acked-by: Arthur Kiyanovski <akiyano@amazon.com>
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Tue, 13 Feb 2024 11:15:02 -0500 you wrote: > IS_ERR() is already using unlikely internally. > > Signed-off-by: Kamal Heib <kheib@redhat.com> > --- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net: ena: Remove unlikely() from IS_ERR() condition https://git.kernel.org/netdev/net-next/c/e8d8acad5a85 You are awesome, thank you!
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 03be2c008c4d..10e70d869cce 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -545,7 +545,7 @@ static int ena_alloc_rx_buffer(struct ena_ring *rx_ring, /* We handle DMA here */ page = ena_alloc_map_page(rx_ring, &dma); - if (unlikely(IS_ERR(page))) + if (IS_ERR(page)) return PTR_ERR(page); netif_dbg(rx_ring->adapter, rx_status, rx_ring->netdev,
IS_ERR() is already using unlikely internally. Signed-off-by: Kamal Heib <kheib@redhat.com> --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)