| Message ID | a721f0c092306b589fae5f44bdaafcd94c60ed14.1707146506.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable build of full Xen for RISC-V | expand |
On 05.02.2024 16:32, Oleksii Kurochko wrote: > Some headers are the same as asm-generic verions of them > so use them instead of arch-specific headers. Just to mention it (I'll commit this as is, unless asked to do otherwise): With this description I'd expect those "some headers" to be removed by this patch. Yet you're not talking about anything that exists; instead I think you mean "would end up the same". Yet that's precisely what asm-generic/ is for. Hence I would have said something along the lines of "don't need any customization". > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > Acked-by: Jan Beulich <jbeulich@suse.com> > --- > As [PATCH v6 0/9] Introduce generic headers > (https://lore.kernel.org/xen-devel/cover.1703072575.git.oleksii.kurochko@gmail.com/) > is not stable, the list in asm/Makefile can be changed, but the changes will > be easy. Or wait - doesn't this mean the change here can't be committed yet? I know the cover letter specifies dependencies, yet I think we need to come to a point where this large series won't need re-posting again and again. Jan
On Mon, 2024-02-12 at 16:03 +0100, Jan Beulich wrote: > On 05.02.2024 16:32, Oleksii Kurochko wrote: > > Some headers are the same as asm-generic verions of them > > so use them instead of arch-specific headers. > > Just to mention it (I'll commit this as is, unless asked to do > otherwise): > With this description I'd expect those "some headers" to be removed > by > this patch. Yet you're not talking about anything that exists; > instead I > think you mean "would end up the same". Yet that's precisely what > asm-generic/ is for. Hence I would have said something along the > lines of > "don't need any customization". Agree that "some headers" isn't the best one option to describe the changes. Perhaps, it would be better to specify the headers which would end up the same as asm-generic's version. Thanks for such notes! > > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > > Acked-by: Jan Beulich <jbeulich@suse.com> > > --- > > As [PATCH v6 0/9] Introduce generic headers > > ( > > https://lore.kernel.org/xen-devel/cover.1703072575.git.oleksii.kurochko@gmail.com > > /) > > is not stable, the list in asm/Makefile can be changed, but the > > changes will > > be easy. > > Or wait - doesn't this mean the change here can't be committed yet? I > know the cover letter specifies dependencies, yet I think we need to > come > to a point where this large series won't need re-posting again and > again. We can't committed it now because asm-generic version of device.h, which is not commited yet. We can drop the change " generic-y += device.h ", and commit the current one patch, but it sill will require to create a new patch for using of asm-generic/device.h. Or as an option, I can merge "generic-y += device.h" into PATCH 29/30 xen/riscv: enable full Xen build. I don't expect that the of asm-generic headers will changed in riscv/include/asm/Makefile, but it looks to me that it is better to wait until asm-generic/device.h will be in staging branch. If you have better ideas, please share it with me. ~ Oleksii
On 14.02.2024 10:54, Oleksii wrote: > On Mon, 2024-02-12 at 16:03 +0100, Jan Beulich wrote: >> On 05.02.2024 16:32, Oleksii Kurochko wrote: >>> As [PATCH v6 0/9] Introduce generic headers >>> ( >>> https://lore.kernel.org/xen-devel/cover.1703072575.git.oleksii.kurochko@gmail.com >>> /) >>> is not stable, the list in asm/Makefile can be changed, but the >>> changes will >>> be easy. >> >> Or wait - doesn't this mean the change here can't be committed yet? I >> know the cover letter specifies dependencies, yet I think we need to >> come >> to a point where this large series won't need re-posting again and >> again. > We can't committed it now because asm-generic version of device.h, > which is not commited yet. > > We can drop the change " generic-y += device.h ", and commit the > current one patch, but it sill will require to create a new patch for > using of asm-generic/device.h. Or as an option, I can merge "generic-y > += device.h" into PATCH 29/30 xen/riscv: enable full Xen build. > > I don't expect that the of asm-generic headers will changed in > riscv/include/asm/Makefile, but it looks to me that it is better to > wait until asm-generic/device.h will be in staging branch. > > > If you have better ideas, please share it with me. My main point was that the interdependencies here have grown too far, imo. The more that while having dependencies stated in the cover letter is useful, while committing (and also reviewing) I for one would typically only look at the individual patches. For this patch alone, maybe it would be more obvious that said dependency exists if it was last on the asm-generic series, rather than part of the series here (which depends on that other series anyway). That series now looks to be making some progress, and it being a prereq for here it may be prudent to focus on getting that one in, before re-posting here. Jan
On Wed, 2024-02-14 at 11:03 +0100, Jan Beulich wrote: > On 14.02.2024 10:54, Oleksii wrote: > > On Mon, 2024-02-12 at 16:03 +0100, Jan Beulich wrote: > > > On 05.02.2024 16:32, Oleksii Kurochko wrote: > > > > As [PATCH v6 0/9] Introduce generic headers > > > > ( > > > > https://lore.kernel.org/xen-devel/cover.1703072575.git.oleksii.kurochko@gmail.com > > > > /) > > > > is not stable, the list in asm/Makefile can be changed, but > > > > the > > > > changes will > > > > be easy. > > > > > > Or wait - doesn't this mean the change here can't be committed > > > yet? I > > > know the cover letter specifies dependencies, yet I think we need > > > to > > > come > > > to a point where this large series won't need re-posting again > > > and > > > again. > > We can't committed it now because asm-generic version of device.h, > > which is not commited yet. > > > > We can drop the change " generic-y += device.h ", and commit the > > current one patch, but it sill will require to create a new patch > > for > > using of asm-generic/device.h. Or as an option, I can merge > > "generic-y > > += device.h" into PATCH 29/30 xen/riscv: enable full Xen build. > > > > I don't expect that the of asm-generic headers will changed in > > riscv/include/asm/Makefile, but it looks to me that it is better to > > wait until asm-generic/device.h will be in staging branch. > > > > > > If you have better ideas, please share it with me. > > My main point was that the interdependencies here have grown too far, > imo. The more that while having dependencies stated in the cover > letter > is useful, while committing (and also reviewing) I for one would > typically only look at the individual patches. > > For this patch alone, maybe it would be more obvious that said > dependency exists if it was last on the asm-generic series, rather > than part of the series here (which depends on that other series > anyway). That series now looks to be making some progress, and it > being > a prereq for here it may be prudent to focus on getting that one in, > before re-posting here. I'll be more specific next time regarding dependencies and specify what a prereq changes are. Considering that asm-generic/device.h was merged to staging branch. It seems to me that there are no more additional prereqs for this patch. ~ Oleksii
diff --git a/xen/arch/riscv/include/asm/Makefile b/xen/arch/riscv/include/asm/Makefile new file mode 100644 index 0000000000..ced02e26ed --- /dev/null +++ b/xen/arch/riscv/include/asm/Makefile @@ -0,0 +1,12 @@ +# SPDX-License-Identifier: GPL-2.0-only +generic-y += altp2m.h +generic-y += device.h +generic-y += div64.h +generic-y += hardirq.h +generic-y += hypercall.h +generic-y += iocap.h +generic-y += paging.h +generic-y += percpu.h +generic-y += random.h +generic-y += softirq.h +generic-y += vm_event.h