diff mbox series

[net-next,v7,11/11] tcp: get rid of NOT_SPECIFIED reason in tcp_v4/6_do_rcv

Message ID 20240221025732.68157-12-kerneljasonxing@gmail.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series introduce drop reasons for tcp receive path | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next, async
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 961 this patch: 961
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 958 this patch: 958
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 978 this patch: 978
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 14 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-02-21--12-00 (tests: 1454)

Commit Message

Jason Xing Feb. 21, 2024, 2:57 a.m. UTC 
From: Jason Xing <kernelxing@tencent.com>

Finally we can drop this obscure reason in receive path  because
we replaced with many other more accurate reasons before.

Signed-off-by: Jason Xing <kernelxing@tencent.com>
--
v5:
1. change the misspelled word in the title
---
 net/ipv4/tcp_ipv4.c | 1 -
 net/ipv6/tcp_ipv6.c | 1 -
 2 files changed, 2 deletions(-)

Comments

Eric Dumazet Feb. 21, 2024, 2:47 p.m. UTC | #1 
On Wed, Feb 21, 2024 at 3:58 AM Jason Xing <kerneljasonxing@gmail.com> wrote:
>
> From: Jason Xing <kernelxing@tencent.com>
>
> Finally we can drop this obscure reason in receive path  because
> we replaced with many other more accurate reasons before.


This is not obscure, but the generic reason.

I don't think we can review this patch easily, I would rather squash
it in prior patches.

>
> Signed-off-by: Jason Xing <kernelxing@tencent.com>
> --
> v5:
> 1. change the misspelled word in the title
> ---
>  net/ipv4/tcp_ipv4.c | 1 -
>  net/ipv6/tcp_ipv6.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index c886c671fae9..82e63f6af34b 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -1907,7 +1907,6 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
>                 return 0;
>         }
>
> -       reason = SKB_DROP_REASON_NOT_SPECIFIED;
>         if (tcp_checksum_complete(skb))
>                 goto csum_err;
>
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index f260c28e5b18..56c3a3bf1323 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1623,7 +1623,6 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
>         if (np->rxopt.all)
>                 opt_skb = skb_clone_and_charge_r(skb, sk);
>
> -       reason = SKB_DROP_REASON_NOT_SPECIFIED;
>         if (sk->sk_state == TCP_ESTABLISHED) { /* Fast path */
>                 struct dst_entry *dst;
>
> --
> 2.37.3
>
Jason Xing Feb. 22, 2024, 2:16 a.m. UTC | #2 
On Wed, Feb 21, 2024 at 10:47 PM Eric Dumazet <edumazet@google.com> wrote:
>
> On Wed, Feb 21, 2024 at 3:58 AM Jason Xing <kerneljasonxing@gmail.com> wrote:
> >
> > From: Jason Xing <kernelxing@tencent.com>
> >
> > Finally we can drop this obscure reason in receive path  because
> > we replaced with many other more accurate reasons before.
>
>
> This is not obscure, but the generic reason.
>
> I don't think we can review this patch easily, I would rather squash
> it in prior patches.

I will squash it in patch [10/11] since that patch just finishes
adding specific reasons in the v4/v6 receive path.

Thanks,
Jason
diff mbox series

Patch

diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index c886c671fae9..82e63f6af34b 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1907,7 +1907,6 @@  int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
 		return 0;
 	}
 
-	reason = SKB_DROP_REASON_NOT_SPECIFIED;
 	if (tcp_checksum_complete(skb))
 		goto csum_err;
 
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index f260c28e5b18..56c3a3bf1323 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -1623,7 +1623,6 @@  int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
 	if (np->rxopt.all)
 		opt_skb = skb_clone_and_charge_r(skb, sk);
 
-	reason = SKB_DROP_REASON_NOT_SPECIFIED;
 	if (sk->sk_state == TCP_ESTABLISHED) { /* Fast path */
 		struct dst_entry *dst;