| Message ID | 20240222153848.2374782-5-vineeth.karumanchi@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: macb: WOL enhancements | expand |
On 22/02/2024 16:38, Vineeth Karumanchi wrote: > WOL modes such as magic-packet should be an OS policy. > Leverage MACB_CAPS_WOL on supported devices to advertise > supported modes through ethtool. Use ethtool to activate > the required mode. > > Suggested-by: Andrew Lunn <andrew@lunn.ch> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Feb 22, 2024 at 09:08:48PM +0530, Vineeth Karumanchi wrote: > WOL modes such as magic-packet should be an OS policy. > Leverage MACB_CAPS_WOL on supported devices to advertise > supported modes through ethtool. Use ethtool to activate > the required mode. According to the description of the property, it indicates whether magic packet is supported by the h/w or not. Enabling WOL or not is a separate matter. OTOH, I would think WOL support would be implied by compatible properties. No objection from me, just highlighting the distinction. > > Suggested-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com> > --- > Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml > index bf8894a0257e..096309bf3235 100644 > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml > @@ -141,6 +141,7 @@ patternProperties: > > magic-packet: > type: boolean > + deprecated: true > description: > Indicates that the hardware supports waking up via magic packet. > > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml index bf8894a0257e..096309bf3235 100644 --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml @@ -141,6 +141,7 @@ patternProperties: magic-packet: type: boolean + deprecated: true description: Indicates that the hardware supports waking up via magic packet.
WOL modes such as magic-packet should be an OS policy. Leverage MACB_CAPS_WOL on supported devices to advertise supported modes through ethtool. Use ethtool to activate the required mode. Suggested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com> --- Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 + 1 file changed, 1 insertion(+)