[0/4] usb: typec: ucsi: Expand SOP/SOP' Discovery

Message

Jameson Thies Feb. 23, 2024, 1:03 a.m. UTC

Hi Heikki,

This patch series expands support for partner and cable discover in the
UCSI driver. There are a few pieces here.

1. Some cleanup of the GET_CABLE_PROP definitions in ucsi.h.
2. Cable discovery and registration with the USB Type-C connector class.
3. Partner/Cable identity registration with the USB Type-C connector
class.
4. SOP' alternate mode registration with the USB-C connector class using
a cable plug.

These have been tested on a v6.6 kernel build running a usermode ppm
with a Realtek EVB. Let me know if you have any questions.

Thanks,
Jameson

Jameson Thies (4):
  usb: typec: ucsi: Clean up UCSI_CABLE_PROP macros
  usb: typec: ucsi: Register cables based on GET_CABLE_PROPERTY
  usb: typec: ucsi: Register SOP/SOP' Discover Identity Responses
  usb: typec: ucsi: Register SOP' alternate modes with cable plug

 drivers/usb/typec/ucsi/ucsi.c | 206 ++++++++++++++++++++++++++++++++++
 drivers/usb/typec/ucsi/ucsi.h |  40 ++++++-
 2 files changed, 244 insertions(+), 2 deletions(-)


base-commit: 3bf0514dc6f36f81ee11b1becd977cb87b4c90c6

Comments

Dmitry Baryshkov Feb. 23, 2024, 5:34 a.m. UTC | #1

Hi Jameson,

On Fri, 23 Feb 2024 at 03:04, Jameson Thies <[e-mail]> wrote:
>
> Hi Heikki,
>
> This patch series expands support for partner and cable discover in the
> UCSI driver. There are a few pieces here.
>
> 1. Some cleanup of the GET_CABLE_PROP definitions in ucsi.h.
> 2. Cable discovery and registration with the USB Type-C connector class.
> 3. Partner/Cable identity registration with the USB Type-C connector
> class.
> 4. SOP' alternate mode registration with the USB-C connector class using
> a cable plug.
>
> These have been tested on a v6.6 kernel build running a usermode ppm
> with a Realtek EVB. Let me know if you have any questions.

First and the most obvious comment: 6.6 is four months old. I see that
your base commit is the usb-testing tip, however you declare that you
tested only on 6.6. Now I'm confused. Did you test your patches on top
of usb-testing before sending them?

Jameson Thies Feb. 27, 2024, 12:28 a.m. UTC | #2

> First and the most obvious comment: 6.6 is four months old. I see that
> your base commit is the usb-testing tip, however you declare that you
> tested only on 6.6. Now I'm confused. Did you test your patches on top
> of usb-testing before sending them?

Hi Dmitry, sorry for the confusion. I tested this on a v6.6 kernel build
with a few dependent commits cherry-picked to it. I'll re-validate the
series on top of usb-testing.