| Message ID | 20240217001017.29969-37-quic_wcheng@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | a9c83252bff616cf3a38d55b7c6a6ad63667f2dd |
| Headers | show |
| Series | Introduce QC USB SND audio offloading support | expand |
On 17/02/2024 01:10, Wesley Cheng wrote: > Add an example on enabling of USB offload for the Q6DSP. The routing can > be done by the mixer, which can pass the multimedia stream to the USB > backend. > > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > --- > .../devicetree/bindings/sound/qcom,sm8250.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) This broke next. Wesley, are you sure you explained dependencies in this patch? Why is next failing on this now? Best regards, Krzysztof
On Thu, Feb 22, 2024 at 05:24:58PM +0100, Krzysztof Kozlowski wrote: > On 17/02/2024 01:10, Wesley Cheng wrote: > > Add an example on enabling of USB offload for the Q6DSP. The routing can > > be done by the mixer, which can pass the multimedia stream to the USB > > backend. > > > > Acked-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > > --- > > .../devicetree/bindings/sound/qcom,sm8250.yaml | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > This broke next. > Wesley, are you sure you explained dependencies in this patch? Why is > next failing on this now? It's surprising to see this merged at all while the series is still in review?
On Thu, Feb 22, 2024 at 04:50:08PM +0000, Mark Brown wrote: > On Thu, Feb 22, 2024 at 05:24:58PM +0100, Krzysztof Kozlowski wrote: > > On 17/02/2024 01:10, Wesley Cheng wrote: > > > Add an example on enabling of USB offload for the Q6DSP. The routing can > > > be done by the mixer, which can pass the multimedia stream to the USB > > > backend. > > > > > > Acked-by: Rob Herring <robh@kernel.org> > > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > > > --- > > > .../devicetree/bindings/sound/qcom,sm8250.yaml | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > This broke next. > > > Wesley, are you sure you explained dependencies in this patch? Why is > > next failing on this now? > > It's surprising to see this merged at all while the series is still in > review? I took the first 10 and then these dt patches as I thought those were safe to take also given the review. If I should revert them, I'll gladly do so. thanks, greg k-h
On Fri, Feb 23, 2024 at 06:59:30AM +0100, Greg KH wrote: > On Thu, Feb 22, 2024 at 04:50:08PM +0000, Mark Brown wrote: > > On Thu, Feb 22, 2024 at 05:24:58PM +0100, Krzysztof Kozlowski wrote: > > > On 17/02/2024 01:10, Wesley Cheng wrote: > > > > Add an example on enabling of USB offload for the Q6DSP. The routing can > > > > be done by the mixer, which can pass the multimedia stream to the USB > > > > backend. > > > > > > > > Acked-by: Rob Herring <robh@kernel.org> > > > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > > > > --- > > > > .../devicetree/bindings/sound/qcom,sm8250.yaml | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > > This broke next. > > > > > Wesley, are you sure you explained dependencies in this patch? Why is > > > next failing on this now? > > > > It's surprising to see this merged at all while the series is still in > > review? > > I took the first 10 and then these dt patches as I thought those were > safe to take also given the review. If I should revert them, I'll > gladly do so. Now reverted.
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 6f419747273e..e78b8b660fce 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -227,6 +227,21 @@ examples: sound-dai = <&vamacro 0>; }; }; + + usb-dai-link { + link-name = "USB Playback"; + cpu { + sound-dai = <&q6afedai USB_RX>; + }; + + codec { + sound-dai = <&usbdai USB_RX>; + }; + + platform { + sound-dai = <&q6routing>; + }; + }; }; - |