| Message ID | pull.1663.v2.git.git.1708660111.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | This PR enables a successful git build on z/OS. | expand |
"Haritha via GitGitGadget" <gitgitgadget@gmail.com> writes: > Since the z/OS linker does not support searching dynamic libraries, and the > current setting of CC_LD_DYNPATH results in a directory to be supplied to > the link step with no option as the suffix, it causes a linker error because > the z/OS LD linker does not accept directories as input. Therefore, we > workaround this by adding the -L option. Hmph, do we still need that CC_LD_DYNPATH hack, with 07bbe4ca (Merge branch 'jc/make-libpath-template', 2024-02-06) already in 'master'? > And, Introduced z/OS (OS/390) as a > platform in config.mak.uname Add support for z/OS (OS/390) in config.mak.uname. or something (cf. Documentation/SubmittingPatches)? > Thanks for taking the time to contribute to Git! Please be advised that the > Git community does not use github.com for their contributions. Instead, we > use a mailing list (git@vger.kernel.org) for code submissions, code reviews, > and bug reports. Nevertheless, you can use GitGitGadget > (https://gitgitgadget.github.io/) to conveniently send your Pull Requests > commits to our mailing list. > > Please read the "guidelines for contributing" linked above! For whom is the above message addressed? Who is expected to read that guidelines?
Since the z/OS linker does not support searching dynamic libraries, and the current setting of CC_LD_DYNPATH results in a directory to be supplied to the link step with no option as the suffix, it causes a linker error because the z/OS LD linker does not accept directories as input. Therefore, we workaround this by adding the -L option. And, Introduced z/OS (OS/390) as a platform in config.mak.uname Thanks for taking the time to contribute to Git! Please be advised that the Git community does not use github.com for their contributions. Instead, we use a mailing list (git@vger.kernel.org) for code submissions, code reviews, and bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/) to conveniently send your Pull Requests commits to our mailing list. Please read the "guidelines for contributing" linked above! Haritha D (2): build: support z/OS (OS/390). an improvement: removed configure.ac changes config.mak.uname | 12 ++++++++++++ 1 file changed, 12 insertions(+) base-commit: f41f85c9ec8d4d46de0fd5fded88db94d3ec8c11 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1663%2FHarithaIBM%2Fzos-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1663/HarithaIBM/zos-v2 Pull-Request: https://github.com/git/git/pull/1663 Range-diff vs v1: 1: 2eddc8f8860 ! 1: 53e211d7a65 This PR enables a successful git build on z/OS. @@ Metadata Author: Haritha D <harithamma.d@ibm.com> ## Commit message ## - This PR enables a successful git build on z/OS. + build: support z/OS (OS/390). Since the z/OS linker does not support searching dynamic libraries, and the current setting of CC_LD_DYNPATH results in a directory to be supplied to the link step with no option as the suffix, it causes a linker error because the z/OS LD linker does not accept directories as input. - Therefore, we workaround this by adding the -L option. - And, Introduced z/OS (OS/390) as a platform in config.mak.uname + Therefore, -L option is added. + Also introduced z/OS (OS/390) as a platform in config.mak.uname Signed-off-by: Haritha D <harithamma.d@ibm.com> -: ----------- > 2: 05df5d7e2d5 an improvement: removed configure.ac changes