diff mbox series

Build guest_memfd_test also on arm64.

Message ID 20240222-memfd-v1-1-7d39680286f1@linux.dev (mailing list archive)
State New, archived
Headers show
Series Build guest_memfd_test also on arm64. | expand

Commit Message

Itaru Kitayama Feb. 21, 2024, 11:38 p.m. UTC 
---
on arm64 KVM_CAP_GUEST_MEMDF capability is not enabled, but
guest_memfd_test can build on arm64, let's build it on arm64 as well.

Signed-off-by: Itaru Kitayama <itaru.kitayama@fujitsu.com>
---
 tools/testing/selftests/kvm/Makefile | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 39133352cbed6626956d38ed72012f49b0421e7b
change-id: 20240222-memfd-7285f9564c1e

Best regards,

Comments

Paolo Bonzini Feb. 23, 2024, 8:57 a.m. UTC | #1 
On Thu, Feb 22, 2024 at 12:44 AM Itaru Kitayama
<itaru.kitayama@linux.dev> wrote:
> on arm64 KVM_CAP_GUEST_MEMDF capability is not enabled, but
> guest_memfd_test can build on arm64, let's build it on arm64 as well.

The test will be skipped, so there's no point in compiling it.

Paolo

> Signed-off-by: Itaru Kitayama <itaru.kitayama@fujitsu.com>
> ---
>  tools/testing/selftests/kvm/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
> index 492e937fab00..8a4f8afb81ca 100644
> --- a/tools/testing/selftests/kvm/Makefile
> +++ b/tools/testing/selftests/kvm/Makefile
> @@ -158,6 +158,7 @@ TEST_GEN_PROGS_aarch64 += access_tracking_perf_test
>  TEST_GEN_PROGS_aarch64 += demand_paging_test
>  TEST_GEN_PROGS_aarch64 += dirty_log_test
>  TEST_GEN_PROGS_aarch64 += dirty_log_perf_test
> +TEST_GEN_PROGS_aarch64 += guest_memfd_test
>  TEST_GEN_PROGS_aarch64 += guest_print_test
>  TEST_GEN_PROGS_aarch64 += get-reg-list
>  TEST_GEN_PROGS_aarch64 += kvm_create_max_vcpus
>
> ---
> base-commit: 39133352cbed6626956d38ed72012f49b0421e7b
> change-id: 20240222-memfd-7285f9564c1e
>
> Best regards,
> --
> Itaru Kitayama <itaru.kitayama@linux.dev>
>
Itaru Kitayama May 8, 2024, 6:41 a.m. UTC | #2 
Hi Paolo,

> On Feb 23, 2024, at 17:57, Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> On Thu, Feb 22, 2024 at 12:44 AM Itaru Kitayama
> <itaru.kitayama@linux.dev> wrote:
>> on arm64 KVM_CAP_GUEST_MEMDF capability is not enabled, but
>> guest_memfd_test can build on arm64, let's build it on arm64 as well.
> 
> The test will be skipped, so there's no point in compiling it.

It’s not merged yet, but the Arm CCA support series V2 is out there, would you consider building it for arm64
as well?

Thanks,
Itaru.

> 
> Paolo
> 
>> Signed-off-by: Itaru Kitayama <itaru.kitayama@fujitsu.com>
>> ---
>> tools/testing/selftests/kvm/Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
>> index 492e937fab00..8a4f8afb81ca 100644
>> --- a/tools/testing/selftests/kvm/Makefile
>> +++ b/tools/testing/selftests/kvm/Makefile
>> @@ -158,6 +158,7 @@ TEST_GEN_PROGS_aarch64 += access_tracking_perf_test
>> TEST_GEN_PROGS_aarch64 += demand_paging_test
>> TEST_GEN_PROGS_aarch64 += dirty_log_test
>> TEST_GEN_PROGS_aarch64 += dirty_log_perf_test
>> +TEST_GEN_PROGS_aarch64 += guest_memfd_test
>> TEST_GEN_PROGS_aarch64 += guest_print_test
>> TEST_GEN_PROGS_aarch64 += get-reg-list
>> TEST_GEN_PROGS_aarch64 += kvm_create_max_vcpus
>> 
>> ---
>> base-commit: 39133352cbed6626956d38ed72012f49b0421e7b
>> change-id: 20240222-memfd-7285f9564c1e
>> 
>> Best regards,
>> --
>> Itaru Kitayama <itaru.kitayama@linux.dev>
>> 
>
Itaru Kitayama May 13, 2024, 1:46 a.m. UTC | #3 
> On May 8, 2024, at 15:41, Itaru Kitayama <itaru.kitayama@linux.dev> wrote:
> 
> Hi Paolo,
> 
>> On Feb 23, 2024, at 17:57, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> 
>> On Thu, Feb 22, 2024 at 12:44 AM Itaru Kitayama
>> <itaru.kitayama@linux.dev> wrote:
>>> on arm64 KVM_CAP_GUEST_MEMDF capability is not enabled, but
>>> guest_memfd_test can build on arm64, let's build it on arm64 as well.
>> 
>> The test will be skipped, so there's no point in compiling it.
> 
> It’s not merged yet, but the Arm CCA support series V2 is out there, would you consider building it for arm64
> as well?

Unless KVM_CAP_GUEST_MEMFD is supported in arm64, you think it should not be built at all?
Then, I will build them locally for now.

Thanks,
Itaru.

> 
> Thanks,
> Itaru.
> 
>> 
>> Paolo
>> 
>>> Signed-off-by: Itaru Kitayama <itaru.kitayama@fujitsu.com>
>>> ---
>>> tools/testing/selftests/kvm/Makefile | 1 +
>>> 1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
>>> index 492e937fab00..8a4f8afb81ca 100644
>>> --- a/tools/testing/selftests/kvm/Makefile
>>> +++ b/tools/testing/selftests/kvm/Makefile
>>> @@ -158,6 +158,7 @@ TEST_GEN_PROGS_aarch64 += access_tracking_perf_test
>>> TEST_GEN_PROGS_aarch64 += demand_paging_test
>>> TEST_GEN_PROGS_aarch64 += dirty_log_test
>>> TEST_GEN_PROGS_aarch64 += dirty_log_perf_test
>>> +TEST_GEN_PROGS_aarch64 += guest_memfd_test
>>> TEST_GEN_PROGS_aarch64 += guest_print_test
>>> TEST_GEN_PROGS_aarch64 += get-reg-list
>>> TEST_GEN_PROGS_aarch64 += kvm_create_max_vcpus
>>> 
>>> ---
>>> base-commit: 39133352cbed6626956d38ed72012f49b0421e7b
>>> change-id: 20240222-memfd-7285f9564c1e
>>> 
>>> Best regards,
>>> --
>>> Itaru Kitayama <itaru.kitayama@linux.dev>
>>> 
>> 
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
index 492e937fab00..8a4f8afb81ca 100644
--- a/tools/testing/selftests/kvm/Makefile
+++ b/tools/testing/selftests/kvm/Makefile
@@ -158,6 +158,7 @@  TEST_GEN_PROGS_aarch64 += access_tracking_perf_test
 TEST_GEN_PROGS_aarch64 += demand_paging_test
 TEST_GEN_PROGS_aarch64 += dirty_log_test
 TEST_GEN_PROGS_aarch64 += dirty_log_perf_test
+TEST_GEN_PROGS_aarch64 += guest_memfd_test
 TEST_GEN_PROGS_aarch64 += guest_print_test
 TEST_GEN_PROGS_aarch64 += get-reg-list
 TEST_GEN_PROGS_aarch64 += kvm_create_max_vcpus