| Message ID | 20240222090042.12609-1-john.g.garry@oracle.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net/staging: Don't bother filling in ethtool driver version | expand |
Thu, Feb 22, 2024 at 10:00:39AM CET, john.g.garry@oracle.com wrote: >The drivers included in this series set the ethtool driver version to the >same as the default, UTS_RELEASE, so don't both doing this. > >As noted by Masahiro in [0], with CONFIG_MODVERSIONS=y, some drivers could >be built as modules against a different kernel tree with differing >UTS_RELEASE. As such, these changes could lead to a change in behaviour. >However, defaulting to the core kernel UTS_RELEASE would be expected >behaviour. > >These patches are for netdev and staging trees, and I hope that the >respective maintainers can pick up the patches separately. > >[0] https://lore.kernel.org/all/CAK7LNASfTW+OMk1cJJWb4E6P+=k0FEsm_=6FDfDF_mTrxJCSMQ@mail.gmail.com/ > >John Garry (3): > rocker: Don't bother filling in ethtool driver version > net: team: Don't bother filling in ethtool driver version > staging: octeon: Don't bother filling in ethtool driver version > > drivers/net/ethernet/rocker/rocker_main.c | 2 -- > drivers/net/team/team.c | 2 -- > drivers/staging/octeon/ethernet-mdio.c | 2 -- > 3 files changed, 6 deletions(-) The set looks fine to me. Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 22 Feb 2024 09:00:39 +0000 you wrote: > The drivers included in this series set the ethtool driver version to the > same as the default, UTS_RELEASE, so don't both doing this. > > As noted by Masahiro in [0], with CONFIG_MODVERSIONS=y, some drivers could > be built as modules against a different kernel tree with differing > UTS_RELEASE. As such, these changes could lead to a change in behaviour. > However, defaulting to the core kernel UTS_RELEASE would be expected > behaviour. > > [...] Here is the summary with links: - [net-next,1/3] rocker: Don't bother filling in ethtool driver version https://git.kernel.org/netdev/net-next/c/23fe265fbfbc - [net-next,2/3] net: team: Don't bother filling in ethtool driver version https://git.kernel.org/netdev/net-next/c/0a4e1b453a8a - [3/3] staging: octeon: Don't bother filling in ethtool driver version (no matching commit) You are awesome, thank you!