| Message ID | 1708675339-8180-1-git-send-email-shengjiu.wang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] arm64: dts: imx8mp-evk: Add HDMI audio sound card support | expand |
Hi, thanks for the patch. Am Freitag, 23. Februar 2024, 09:02:18 CET schrieb Shengjiu Wang: > The AUD2HTX is a digital module that provides a bridge between > the Audio Subsystem and the HDMI RTX Subsystem. This > module includes intermediate storage to queue SDMA transactions > prior to being synchronized and passed to the HDMI > RTX Subsystem over the Audio Link. > > AUD2HTX works as the cpu dai in HDMI audio sound card. > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 12 ++++++++++++ > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > index f87fa5a948cc..63f6e72fa18a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > @@ -138,6 +138,14 @@ simple-audio-card,codec { > > }; > > + sound-hdmi { > + compatible = "fsl,imx-audio-hdmi"; > + model = "audio-hdmi"; > + audio-cpu = <&aud2htx>; > + hdmi-out; > + status = "okay"; No need for 'status' here. Don't you need to configure the PAI as well? See [1] for downstream implementation. I'm wondering because I had to hack something similar. Without I got no HDMI audio. Best regards, Alexander [1] https://github.com/Freescale/linux-fslc/blob/6.1-2.0.x-imx/drivers/gpu/drm/imx/imx8mp-hdmi-pavi.c#L51-L59 > + }; > + > reserved-memory { > #address-cells = <2>; > #size-cells = <2>; > @@ -191,6 +199,10 @@ &A53_3 { > cpu-supply = <®_arm>; > }; > > +&aud2htx { > + status = "okay"; > +}; > + > &eqos { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_eqos>; > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 9ab9c057f41e..721ab630d895 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1513,6 +1513,16 @@ micfil: audio-controller@30ca0000 { > status = "disabled"; > }; > > + aud2htx: aud2htx@30cb0000 { > + compatible = "fsl,imx8mp-aud2htx"; > + reg = <0x30cb0000 0x10000>; > + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_AUD2HTX_IPG>; > + clock-names = "bus"; > + dmas = <&sdma2 26 2 0>; > + dma-names = "tx"; > + status = "disabled"; > + }; > }; > > sdma3: dma-controller@30e00000 { >
On Fri, Feb 23, 2024 at 5:06 PM Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > > Hi, > > thanks for the patch. > > Am Freitag, 23. Februar 2024, 09:02:18 CET schrieb Shengjiu Wang: > > The AUD2HTX is a digital module that provides a bridge between > > the Audio Subsystem and the HDMI RTX Subsystem. This > > module includes intermediate storage to queue SDMA transactions > > prior to being synchronized and passed to the HDMI > > RTX Subsystem over the Audio Link. > > > > AUD2HTX works as the cpu dai in HDMI audio sound card. > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 12 ++++++++++++ > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++ > > 2 files changed, 22 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > > index f87fa5a948cc..63f6e72fa18a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > > @@ -138,6 +138,14 @@ simple-audio-card,codec { > > > > }; > > > > + sound-hdmi { > > + compatible = "fsl,imx-audio-hdmi"; > > + model = "audio-hdmi"; > > + audio-cpu = <&aud2htx>; > > + hdmi-out; > > + status = "okay"; > > No need for 'status' here. ok, will remove it. > > Don't you need to configure the PAI as well? See [1] > for downstream implementation. I'm wondering because I had to hack something > similar. Without I got no HDMI audio. Yes, the PAI part is needed. But this commit is just for sound card dts update. Best regards Wang shengjiu > > Best regards, > Alexander > > [1] https://github.com/Freescale/linux-fslc/blob/6.1-2.0.x-imx/drivers/gpu/drm/imx/imx8mp-hdmi-pavi.c#L51-L59 > > > + }; > > + > > reserved-memory { > > #address-cells = <2>; > > #size-cells = <2>; > > @@ -191,6 +199,10 @@ &A53_3 { > > cpu-supply = <®_arm>; > > }; > > > > +&aud2htx { > > + status = "okay"; > > +}; > > + > > &eqos { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_eqos>; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > index 9ab9c057f41e..721ab630d895 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > @@ -1513,6 +1513,16 @@ micfil: audio-controller@30ca0000 { > > status = "disabled"; > > }; > > > > + aud2htx: aud2htx@30cb0000 { > > + compatible = "fsl,imx8mp-aud2htx"; > > + reg = <0x30cb0000 0x10000>; > > + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_AUD2HTX_IPG>; > > + clock-names = "bus"; > > + dmas = <&sdma2 26 2 0>; > > + dma-names = "tx"; > > + status = "disabled"; > > + }; > > }; > > > > sdma3: dma-controller@30e00000 { > > > > > -- > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > Amtsgericht München, HRB 105018 > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > http://www.tq-group.com/ > >
Hello Wang, On Mon, Feb 26, 2024 at 11:06:48AM +0800, Shengjiu Wang wrote: > On Fri, Feb 23, 2024 at 5:06 PM Alexander Stein > <alexander.stein@ew.tq-group.com> wrote: > > Am Freitag, 23. Februar 2024, 09:02:18 CET schrieb Shengjiu Wang: > > > The AUD2HTX is a digital module that provides a bridge between > > > the Audio Subsystem and the HDMI RTX Subsystem. This > > > module includes intermediate storage to queue SDMA transactions > > > prior to being synchronized and passed to the HDMI > > > RTX Subsystem over the Audio Link. > > > > > > AUD2HTX works as the cpu dai in HDMI audio sound card. > > > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> ... > > Don't you need to configure the PAI as well? See [1] > > for downstream implementation. I'm wondering because I had to hack something > > similar. Without I got no HDMI audio. > > Yes, the PAI part is needed. > But this commit is just for sound card dts update. I did try this series (the v3, to be correct) and to me is not working. While I understand this is just the DTS update, did you got any chance to send patches for the remaining bits required to have the functionality working? Am I missing something? Thanks, Francesco
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts index f87fa5a948cc..63f6e72fa18a 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts @@ -138,6 +138,14 @@ simple-audio-card,codec { }; + sound-hdmi { + compatible = "fsl,imx-audio-hdmi"; + model = "audio-hdmi"; + audio-cpu = <&aud2htx>; + hdmi-out; + status = "okay"; + }; + reserved-memory { #address-cells = <2>; #size-cells = <2>; @@ -191,6 +199,10 @@ &A53_3 { cpu-supply = <®_arm>; }; +&aud2htx { + status = "okay"; +}; + &eqos { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_eqos>; diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index 9ab9c057f41e..721ab630d895 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -1513,6 +1513,16 @@ micfil: audio-controller@30ca0000 { status = "disabled"; }; + aud2htx: aud2htx@30cb0000 { + compatible = "fsl,imx8mp-aud2htx"; + reg = <0x30cb0000 0x10000>; + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_AUD2HTX_IPG>; + clock-names = "bus"; + dmas = <&sdma2 26 2 0>; + dma-names = "tx"; + status = "disabled"; + }; }; sdma3: dma-controller@30e00000 {
The AUD2HTX is a digital module that provides a bridge between the Audio Subsystem and the HDMI RTX Subsystem. This module includes intermediate storage to queue SDMA transactions prior to being synchronized and passed to the HDMI RTX Subsystem over the Audio Link. AUD2HTX works as the cpu dai in HDMI audio sound card. Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 12 ++++++++++++ arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++ 2 files changed, 22 insertions(+)