| Message ID | 99d4d711acfc020c8987e96145f2f1f323cbaa3b.1708947112.git.geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 943d4bd67950685901addfa7b07aa3408ce17e7f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI to ADIN1110 | expand |
Hi Geert, On 2/26/24 03:34, Geert Uytterhoeven wrote: > The NET_VENDOR_* Kconfig options are used as gatekeepers. Merely > enabling such an option must not enable any other extra code. > > Fixes: a9f80df4f5144030 ("net: ethernet: adi: requires PHYLIB support") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/net/ethernet/adi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/adi/Kconfig b/drivers/net/ethernet/adi/Kconfig > index c91b4dcef4ec2f5f..760a9a60bc15c184 100644 > --- a/drivers/net/ethernet/adi/Kconfig > +++ b/drivers/net/ethernet/adi/Kconfig > @@ -7,7 +7,6 @@ config NET_VENDOR_ADI > bool "Analog Devices devices" > default y > depends on SPI > - select PHYLIB > help > If you have a network (Ethernet) card belonging to this class, say Y. > > @@ -22,6 +21,7 @@ config ADIN1110 > tristate "Analog Devices ADIN1110 MAC-PHY" > depends on SPI && NET_SWITCHDEV > select CRC8 > + select PHYLIB > help > Say yes here to build support for Analog Devices ADIN1110 > Low Power 10BASE-T1L Ethernet MAC-PHY. I sent the same patch last night (local time): https://lore.kernel.org/lkml/20240226074820.29250-1-rdunlap@infradead.org/ Hopefully one of them can be merged soon.
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Mon, 26 Feb 2024 12:34:02 +0100 you wrote: > The NET_VENDOR_* Kconfig options are used as gatekeepers. Merely > enabling such an option must not enable any other extra code. > > Fixes: a9f80df4f5144030 ("net: ethernet: adi: requires PHYLIB support") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/net/ethernet/adi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI to ADIN1110 https://git.kernel.org/netdev/net/c/943d4bd67950 You are awesome, thank you!
diff --git a/drivers/net/ethernet/adi/Kconfig b/drivers/net/ethernet/adi/Kconfig index c91b4dcef4ec2f5f..760a9a60bc15c184 100644 --- a/drivers/net/ethernet/adi/Kconfig +++ b/drivers/net/ethernet/adi/Kconfig @@ -7,7 +7,6 @@ config NET_VENDOR_ADI bool "Analog Devices devices" default y depends on SPI - select PHYLIB help If you have a network (Ethernet) card belonging to this class, say Y. @@ -22,6 +21,7 @@ config ADIN1110 tristate "Analog Devices ADIN1110 MAC-PHY" depends on SPI && NET_SWITCHDEV select CRC8 + select PHYLIB help Say yes here to build support for Analog Devices ADIN1110 Low Power 10BASE-T1L Ethernet MAC-PHY.
The NET_VENDOR_* Kconfig options are used as gatekeepers. Merely enabling such an option must not enable any other extra code. Fixes: a9f80df4f5144030 ("net: ethernet: adi: requires PHYLIB support") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/net/ethernet/adi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)