| Message ID | 20240227092922.1734998-1-Kelly_Hung@asus.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/2] dt-bindings: arm: aspeed: add ASUS X4TF board | expand |
On 27/02/2024 10:29, Kelly Hung wrote: > Document the new compatibles used on ASUS X4TF. > > Changelog > Changes in v3 > - correct string to asus,x4tf-bmc Changelog goes after ---. Again: what happened with the tags? Why aren't you responding to comments you receive? Best regards, Krzysztof
Hi, Krzysztof, I correct my change log > Document the new compatibles used on ASUS X4TF. > > Changelog > Changes in v3 > --- The new compatible is a BMC for a ASUS X4TF server which use a ast2600-a3 chip, so correct string to asus,x4tf-bmc Do I need to resend v3 patch again with the correct change log? Thanks for review. Best Regards Kelly -----Original Message----- From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Sent: Tuesday, February 27, 2024 6:02 PM To: Kelly Hung <ppighouse@gmail.com>; robh+dt@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; openbmc@lists.ozlabs.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>; AllenYY Hsu(許幼岳) <AllenYY_Hsu@asus.com> Subject: Re: [PATCH v3 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board External email : Ensure your email is secure before opening links and attachments. On 27/02/2024 10:29, Kelly Hung wrote: > Document the new compatibles used on ASUS X4TF. > > Changelog > Changes in v3 > - correct string to asus,x4tf-bmc Changelog goes after ---. Again: what happened with the tags? Why aren't you responding to comments you receive? Best regards, Krzysztof <p></p> =================================================================================================================================== This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK. For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish. ===================================================================================================================================
On 29/02/2024 08:45, Kelly Hung(洪嘉莉) wrote: > Hi, Krzysztof, > > I correct my change log >> Document the new compatibles used on ASUS X4TF. >> >> Changelog >> Changes in v3 >> --- The new compatible is a BMC for a ASUS X4TF server which use a ast2600-a3 chip, so correct string to asus,x4tf-bmc > > Do I need to resend v3 patch again with the correct change log? You need to send v4 with correct changelog and tags. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 749ee54a3..0d72a1a9d 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -74,6 +74,7 @@ properties: - ampere,mtmitchell-bmc - aspeed,ast2600-evb - aspeed,ast2600-evb-a1 + - asus,x4tf-bmc - facebook,bletchley-bmc - facebook,cloudripper-bmc - facebook,elbert-bmc
Document the new compatibles used on ASUS X4TF. Changelog Changes in v3 - correct string to asus,x4tf-bmc Signed-off-by: Kelly Hung <Kelly_Hung@asus.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)