| Message ID | 20240227175513.8703-1-pvkumar5749404@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Correcting the spelling mistake in selftests drivers/net testing | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Please fix the patch subject to include appropriate prefixes and rephrase a bit like this: Subject: [PATCH net-next] selftests: net: Correct couple of spelling mistakes pw-bot: cr Tue, Feb 27, 2024 at 06:55:13PM CET, pvkumar5749404@gmail.com wrote: >Changes : > - "excercise" is corrected to "exercise" in drivers/net/mlxsw/spectrum-2/tc_flower.sh > - "mutliple" is corrected to "multiple" in drivers/net/netdevsim/ethtool-fec.sh > >Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com> >--- > .../testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh | 2 +- > tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh >index 616d3581419c..31252bc8775e 100755 >--- a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh >+++ b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh >@@ -869,7 +869,7 @@ bloom_simple_test() > bloom_complex_test() > { > # Bloom filter index computation is affected from region ID, eRP >- # ID and from the region key size. In order to excercise those parts >+ # ID and from the region key size. In order to exercise those parts > # of the Bloom filter code, use a series of regions, each with a > # different key size and send packet that should hit all of them. > local index >diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh >index 7d7829f57550..6c52ce1b0450 100755 >--- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh >+++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh >@@ -49,7 +49,7 @@ for o in llrs rs; do > Active FEC encoding: ${o^^}" > done > >-# Test mutliple bits >+# Test multiple bits > $ETHTOOL --set-fec $NSIM_NETDEV encoding rs llrs > check $? > s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2) >-- >2.34.1 > >
On Wed, Feb 28, 2024 at 1:20 PM Jiri Pirko <jiri@resnulli.us> wrote: > > Please fix the patch subject to include appropriate prefixes and > rephrase a bit like this: > > Subject: [PATCH net-next] selftests: net: Correct couple of spelling mistakes > > pw-bot: cr > > > Tue, Feb 27, 2024 at 06:55:13PM CET, pvkumar5749404@gmail.com wrote: > >Changes : > > - "excercise" is corrected to "exercise" in drivers/net/mlxsw/spectrum-2/tc_flower.sh > > - "mutliple" is corrected to "multiple" in drivers/net/netdevsim/ethtool-fec.sh > > > >Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com> > >--- > > .../testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh | 2 +- > > tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh > >index 616d3581419c..31252bc8775e 100755 > >--- a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh > >+++ b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh > >@@ -869,7 +869,7 @@ bloom_simple_test() > > bloom_complex_test() > > { > > # Bloom filter index computation is affected from region ID, eRP > >- # ID and from the region key size. In order to excercise those parts > >+ # ID and from the region key size. In order to exercise those parts > > # of the Bloom filter code, use a series of regions, each with a > > # different key size and send packet that should hit all of them. > > local index > >diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh > >index 7d7829f57550..6c52ce1b0450 100755 > >--- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh > >+++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh > >@@ -49,7 +49,7 @@ for o in llrs rs; do > > Active FEC encoding: ${o^^}" > > done > > > >-# Test mutliple bits > >+# Test multiple bits > > $ETHTOOL --set-fec $NSIM_NETDEV encoding rs llrs > > check $? > > s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2) > >-- > >2.34.1 > > > >
On Wed, Feb 28, 2024 at 1:20 PM Jiri Pirko <jiri@resnulli.us> wrote: > > Please fix the patch subject to include appropriate prefixes and > rephrase a bit like this: > > Subject: [PATCH net-next] selftests: net: Correct couple of spelling mistakes > > pw-bot: cr > > > Tue, Feb 27, 2024 at 06:55:13PM CET, pvkumar5749404@gmail.com wrote: > >Changes : > > - "excercise" is corrected to "exercise" in drivers/net/mlxsw/spectrum-2/tc_flower.sh > > - "mutliple" is corrected to "multiple" in drivers/net/netdevsim/ethtool-fec.sh > > > >Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com> > >--- > > .../testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh | 2 +- > > tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh > >index 616d3581419c..31252bc8775e 100755 > >--- a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh > >+++ b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh > >@@ -869,7 +869,7 @@ bloom_simple_test() > > bloom_complex_test() > > { > > # Bloom filter index computation is affected from region ID, eRP > >- # ID and from the region key size. In order to excercise those parts > >+ # ID and from the region key size. In order to exercise those parts > > # of the Bloom filter code, use a series of regions, each with a > > # different key size and send packet that should hit all of them. > > local index > >diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh > >index 7d7829f57550..6c52ce1b0450 100755 > >--- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh > >+++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh > >@@ -49,7 +49,7 @@ for o in llrs rs; do > > Active FEC encoding: ${o^^}" > > done > > > >-# Test mutliple bits > >+# Test multiple bits > > $ETHTOOL --set-fec $NSIM_NETDEV encoding rs llrs > > check $? > > s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2) > >-- > >2.34.1 > > > >
Prabhav, I'm not sure what you are trying to do, but you have to re-submit the patch, preferably using git-send-email or another email client you use. Wed, Feb 28, 2024 at 09:42:01AM CET, pvkumar5749404@gmail.com wrote: >On Wed, Feb 28, 2024 at 1:20 PM Jiri Pirko <jiri@resnulli.us> wrote: >> >> Please fix the patch subject to include appropriate prefixes and >> rephrase a bit like this: >> >> Subject: [PATCH net-next] selftests: net: Correct couple of spelling mistakes >> >> pw-bot: cr >> >> >> Tue, Feb 27, 2024 at 06:55:13PM CET, pvkumar5749404@gmail.com wrote: >> >Changes : >> > - "excercise" is corrected to "exercise" in drivers/net/mlxsw/spectrum-2/tc_flower.sh >> > - "mutliple" is corrected to "multiple" in drivers/net/netdevsim/ethtool-fec.sh >> > >> >Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com> >> >--- >> > .../testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh | 2 +- >> > tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh | 2 +- >> > 2 files changed, 2 insertions(+), 2 deletions(-) >> > >> >diff --git a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh >> >index 616d3581419c..31252bc8775e 100755 >> >--- a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh >> >+++ b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh >> >@@ -869,7 +869,7 @@ bloom_simple_test() >> > bloom_complex_test() >> > { >> > # Bloom filter index computation is affected from region ID, eRP >> >- # ID and from the region key size. In order to excercise those parts >> >+ # ID and from the region key size. In order to exercise those parts >> > # of the Bloom filter code, use a series of regions, each with a >> > # different key size and send packet that should hit all of them. >> > local index >> >diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh >> >index 7d7829f57550..6c52ce1b0450 100755 >> >--- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh >> >+++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh >> >@@ -49,7 +49,7 @@ for o in llrs rs; do >> > Active FEC encoding: ${o^^}" >> > done >> > >> >-# Test mutliple bits >> >+# Test multiple bits >> > $ETHTOOL --set-fec $NSIM_NETDEV encoding rs llrs >> > check $? >> > s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2) >> >-- >> >2.34.1 >> > >> >
On Wed, Feb 28, 2024 at 3:02 PM Jiri Pirko <jiri@resnulli.us> wrote: > > Prabhav, I'm not sure what you are trying to do, but you have to > re-submit the patch, preferably using git-send-email or another email > client you use. >> Sorry for that. >> Re-Submitted the patch. > > > Wed, Feb 28, 2024 at 09:42:01AM CET, pvkumar5749404@gmail.com wrote: > >On Wed, Feb 28, 2024 at 1:20 PM Jiri Pirko <jiri@resnulli.us> wrote: > >> > >> Please fix the patch subject to include appropriate prefixes and > >> rephrase a bit like this: > >> > >> Subject: [PATCH net-next] selftests: net: Correct couple of spelling mistakes > >> > >> pw-bot: cr > >> > >> > >> Tue, Feb 27, 2024 at 06:55:13PM CET, pvkumar5749404@gmail.com wrote: > >> >Changes : > >> > - "excercise" is corrected to "exercise" in drivers/net/mlxsw/spectrum-2/tc_flower.sh > >> > - "mutliple" is corrected to "multiple" in drivers/net/netdevsim/ethtool-fec.sh > >> > > >> >Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com> > >> >--- > >> > .../testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh | 2 +- > >> > tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh | 2 +- > >> > 2 files changed, 2 insertions(+), 2 deletions(-) > >> > > >> >diff --git a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh > >> >index 616d3581419c..31252bc8775e 100755 > >> >--- a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh > >> >+++ b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh > >> >@@ -869,7 +869,7 @@ bloom_simple_test() > >> > bloom_complex_test() > >> > { > >> > # Bloom filter index computation is affected from region ID, eRP > >> >- # ID and from the region key size. In order to excercise those parts > >> >+ # ID and from the region key size. In order to exercise those parts > >> > # of the Bloom filter code, use a series of regions, each with a > >> > # different key size and send packet that should hit all of them. > >> > local index > >> >diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh > >> >index 7d7829f57550..6c52ce1b0450 100755 > >> >--- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh > >> >+++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh > >> >@@ -49,7 +49,7 @@ for o in llrs rs; do > >> > Active FEC encoding: ${o^^}" > >> > done > >> > > >> >-# Test mutliple bits > >> >+# Test multiple bits > >> > $ETHTOOL --set-fec $NSIM_NETDEV encoding rs llrs > >> > check $? > >> > s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2) > >> >-- > >> >2.34.1 > >> > > >> >
diff --git a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh index 616d3581419c..31252bc8775e 100755 --- a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh +++ b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh @@ -869,7 +869,7 @@ bloom_simple_test() bloom_complex_test() { # Bloom filter index computation is affected from region ID, eRP - # ID and from the region key size. In order to excercise those parts + # ID and from the region key size. In order to exercise those parts # of the Bloom filter code, use a series of regions, each with a # different key size and send packet that should hit all of them. local index diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh index 7d7829f57550..6c52ce1b0450 100755 --- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh +++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh @@ -49,7 +49,7 @@ for o in llrs rs; do Active FEC encoding: ${o^^}" done -# Test mutliple bits +# Test multiple bits $ETHTOOL --set-fec $NSIM_NETDEV encoding rs llrs check $? s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2)
Changes : - "excercise" is corrected to "exercise" in drivers/net/mlxsw/spectrum-2/tc_flower.sh - "mutliple" is corrected to "multiple" in drivers/net/netdevsim/ethtool-fec.sh Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@gmail.com> --- .../testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh | 2 +- tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)