| Message ID | 20240226032227.15255-1-kerneljasonxing@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | introduce drop reasons for tcp receive path | expand |
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Mon, 26 Feb 2024 11:22:17 +0800 you wrote: > From: Jason Xing <kernelxing@tencent.com> > > When I was debugging the reason about why the skb should be dropped in > syn cookie mode, I found out that this NOT_SPECIFIED reason is too > general. Thus I decided to refine it. > > v10 > Link: https://lore.kernel.org/netdev/20240223193321.6549-1-kuniyu@amazon.com/ > 1. fix three nit problems (Kuniyuki) > 2. add reviewed-by tag (Kuniyuki) > > [...] Here is the summary with links: - [net-next,v10,01/10] tcp: add a dropreason definitions and prepare for cookie check https://git.kernel.org/netdev/net-next/c/48e4704aedb9 - [net-next,v10,02/10] tcp: directly drop skb in cookie check for ipv4 https://git.kernel.org/netdev/net-next/c/65be4393f363 - [net-next,v10,03/10] tcp: use drop reasons in cookie check for ipv4 https://git.kernel.org/netdev/net-next/c/a4a69a3719ec - [net-next,v10,04/10] tcp: directly drop skb in cookie check for ipv6 https://git.kernel.org/netdev/net-next/c/ed43e76cdcc4 - [net-next,v10,05/10] tcp: use drop reasons in cookie check for ipv6 https://git.kernel.org/netdev/net-next/c/253541a3c1e4 - [net-next,v10,06/10] tcp: introduce dropreasons in receive path https://git.kernel.org/netdev/net-next/c/3d359faba191 - [net-next,v10,07/10] tcp: add more specific possible drop reasons in tcp_rcv_synsent_state_process() https://git.kernel.org/netdev/net-next/c/e615e3a24ed6 - [net-next,v10,08/10] tcp: add dropreasons in tcp_rcv_state_process() https://git.kernel.org/netdev/net-next/c/7d6ed9afde85 - [net-next,v10,09/10] tcp: make the dropreason really work when calling tcp_rcv_state_process() https://git.kernel.org/netdev/net-next/c/b98256959305 - [net-next,v10,10/10] tcp: make dropreason in tcp_child_process() work https://git.kernel.org/netdev/net-next/c/ee01defe25ba You are awesome, thank you!
From: Jason Xing <kernelxing@tencent.com> When I was debugging the reason about why the skb should be dropped in syn cookie mode, I found out that this NOT_SPECIFIED reason is too general. Thus I decided to refine it. v10 Link: https://lore.kernel.org/netdev/20240223193321.6549-1-kuniyu@amazon.com/ 1. fix three nit problems (Kuniyuki) 2. add reviewed-by tag (Kuniyuki) v9 Link: https://lore.kernel.org/netdev/20240222113003.67558-1-kerneljasonxing@gmail.com/ 1. nit: remove one unneeded 'else' (David) 2. add reviewed-by tags (Eric, David) v8 Link: https://lore.kernel.org/netdev/20240221025732.68157-1-kerneljasonxing@gmail.com/ 1. refine part of codes in patch [03/10] and patch [10/10] (Eric) 2. squash patch [11/11] in the last version into patch [10/11] (Eric) 3. add reviewed-by tags (Eric) v7 Link: https://lore.kernel.org/all/20240219032838.91723-1-kerneljasonxing@gmail.com/ 1. fix some misspelled problem (Kuniyuki) 2. remove redundant codes in tcp_v6_do_rcv() (Kuniyuki) 3. add reviewed-by tag in patch [02/11] (Kuniyuki) v6 Link: https://lore.kernel.org/all/c987d2c79e4a4655166eb8eafef473384edb37fb.camel@redhat.com/ Link: https://lore.kernel.org/all/CAL+tcoAgSjwsmFnDh_Gs9ZgMi-y5awtVx+4VhJPNRADjo7LLSA@mail.gmail.com/ 1. Take one case into consideration in tcp_v6_do_rcv(), behave like old days, or else it will trigger errors (Paolo). 2. Extend NO_SOCKET reason to consider two more reasons for request socket and child socket. v5: Link: https://lore.kernel.org/netdev/20240213134205.8705-1-kerneljasonxing@gmail.com/ Link: https://lore.kernel.org/netdev/20240213140508.10878-1-kerneljasonxing@gmail.com/ 1. Use SKB_DROP_REASON_IP_OUTNOROUTES instead of introducing a new one (Eric, David) 2. Reuse SKB_DROP_REASON_NOMEM to handle failure of request socket allocation (Eric) 3. Reuse NO_SOCKET instead of introducing COOKIE_NOCHILD 4. avoid duplication of these opt_skb tests/actions (Eric) 5. Use new name (TCP_ABORT_ON_DATA) for readability (David) 6. Reuse IP_OUTNOROUTES instead of INVALID_DST (Eric) --- HISTORY This series is combined with 2 series sent before suggested by Jakub. So I'm going to separately write changelogs for each of them. PATCH 1/11 - 5/11 preivious Link: https://lore.kernel.org/netdev/20240213134205.8705-1-kerneljasonxing@gmail.com/ Summary 1. introduce all the dropreasons we need, [1/11] patch. 2. use new dropreasons in ipv4 cookie check, [2/11],[3/11] patch. 3. use new dropreasons ipv6 cookie check, [4/11],[5/11] patch. v4: Link: https://lore.kernel.org/netdev/20240212172302.3f95e454@kernel.org/ 1. Fix misspelled name in Kdoc as suggested by Jakub. v3: Link: https://lore.kernel.org/all/CANn89iK40SoyJ8fS2U5kp3pDruo=zfQNPL-ppOF+LYaS9z-MVA@mail.gmail.com/ 1. Split that patch into some smaller ones as suggested by Eric. v2: Link: https://lore.kernel.org/all/20240204104601.55760-1-kerneljasonxing@gmail.com/ 1. change the title of 2/2 patch. 2. fix some warnings checkpatch tool showed before. 3. use return value instead of adding more parameters suggested by Eric. PATCH 6/11 - 11/11 previous Link: https://lore.kernel.org/netdev/20240213140508.10878-1-kerneljasonxing@gmail.com/ v4: Link: https://lore.kernel.org/netdev/CANn89iJar+H3XkQ8HpsirH7b-_sbFe9NBUdAAO3pNJK3CKr_bg@mail.gmail.com/ Link: https://lore.kernel.org/netdev/20240213131205.4309-1-kerneljasonxing@gmail.com/ Already got rid of @acceptable in tcp_rcv_state_process(), so I need to remove *TCP_CONNREQNOTACCEPTABLE related codes which I wrote in the v3 series. v3: Link: https://lore.kernel.org/all/CANn89iK40SoyJ8fS2U5kp3pDruo=zfQNPL-ppOF+LYaS9z-MVA@mail.gmail.com/ 1. Split that patch into some smaller ones as suggested by Eric. v2: Link: https://lore.kernel.org/all/20240204104601.55760-1-kerneljasonxing@gmail.com/ 1. change the title of 2/2 patch. 2. fix some warnings checkpatch tool showed before. 3. use return value instead of adding more parameters suggested by Eric. Jason Xing (10): tcp: add a dropreason definitions and prepare for cookie check tcp: directly drop skb in cookie check for ipv4 tcp: use drop reasons in cookie check for ipv4 tcp: directly drop skb in cookie check for ipv6 tcp: use drop reasons in cookie check for ipv6 tcp: introduce dropreasons in receive path tcp: add more specific possible drop reasons in tcp_rcv_synsent_state_process() tcp: add dropreasons in tcp_rcv_state_process() tcp: make the dropreason really work when calling tcp_rcv_state_process() tcp: make dropreason in tcp_child_process() work include/net/dropreason-core.h | 26 ++++++++++++++++++++++++-- include/net/tcp.h | 6 +++--- net/ipv4/syncookies.c | 21 ++++++++++++++++----- net/ipv4/tcp_input.c | 24 ++++++++++++++++-------- net/ipv4/tcp_ipv4.c | 17 ++++++++++------- net/ipv4/tcp_minisocks.c | 10 +++++----- net/ipv6/syncookies.c | 18 +++++++++++++++--- net/ipv6/tcp_ipv6.c | 22 ++++++++++++---------- 8 files changed, 101 insertions(+), 43 deletions(-)