| Message ID | 20240228113125.3473685-2-leitao@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3e2f544dd8a33b2f650b32920b9bef103da2a7cd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: collect tstats automatically | expand |
On Wed, Feb 28, 2024 at 03:31:21AM -0800, Breno Leitao wrote: > If the network driver is relying in the net core to do stats allocation, > then we want to dev_get_tstats64() instead of netdev_stats_to_stats64(), > since there are per-cpu stats that needs to be taken in consideration. > > This will also simplify the drivers in regard to statistics. Once the > driver sets NETDEV_PCPU_STAT_TSTATS, it doesn't not need to allocate the > stacks, neither it needs to set `.ndo_get_stats64 = dev_get_tstats64` > for the generic stats collection function anymore. > > Signed-off-by: Breno Leitao <leitao@debian.org> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/net/core/dev.c b/net/core/dev.c index 275fd5259a4a..3577620e39bd 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -10701,6 +10701,8 @@ struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev, ops->ndo_get_stats64(dev, storage); } else if (ops->ndo_get_stats) { netdev_stats_to_stats64(storage, ops->ndo_get_stats(dev)); + } else if (dev->pcpu_stat_type == NETDEV_PCPU_STAT_TSTATS) { + dev_get_tstats64(dev, storage); } else { netdev_stats_to_stats64(storage, &dev->stats); }
If the network driver is relying in the net core to do stats allocation, then we want to dev_get_tstats64() instead of netdev_stats_to_stats64(), since there are per-cpu stats that needs to be taken in consideration. This will also simplify the drivers in regard to statistics. Once the driver sets NETDEV_PCPU_STAT_TSTATS, it doesn't not need to allocate the stacks, neither it needs to set `.ndo_get_stats64 = dev_get_tstats64` for the generic stats collection function anymore. Signed-off-by: Breno Leitao <leitao@debian.org> --- net/core/dev.c | 2 ++ 1 file changed, 2 insertions(+)