diff mbox series

[4/4] dts: arm64: imx8dxl-evk: add lpuart1 and cm40 uart

Message ID 20240228-m4_lpuart-v1-4-9e6947be15e7@nxp.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx8: add cm40 and cm40_uart | expand

Commit Message

Frank Li Feb. 28, 2024, 7:55 p.m. UTC 
Add lpuart1 and cm40 uart.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 50 +++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

Comments

Fabio Estevam Feb. 28, 2024, 8:04 p.m. UTC | #1 
On Wed, Feb 28, 2024 at 4:55 PM Frank Li <Frank.Li@nxp.com> wrote:

> +       modem_reset: modem-reset {
> +               compatible = "gpio-reset";

I don't see this compatible documented.

> +               reset-gpios = <&pca6416_2 0 GPIO_ACTIVE_LOW>;
> +               reset-delay-us = <2000>;
> +               reset-post-delay-ms = <40>;
> +               #reset-cells = <0>;
> +       };
> +
> +       m2_uart1_sel: fixedregulator@101 {

Why is this @101 here? You should remove it.

Passing a unit address without a corresponding reg entry triggers a
dt-schema warning.

We want less warnings dt-schema warnings, not more :-)
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
index 2123d431e0613..b45b0c99fe204 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
@@ -16,6 +16,8 @@  aliases {
 		mmc0 = &usdhc1;
 		mmc1 = &usdhc2;
 		serial0 = &lpuart0;
+		serial1 = &lpuart1;
+		serial6 = &cm40_lpuart;
 	};
 
 	chosen {
@@ -51,6 +53,24 @@  linux,cma {
 		};
 	};
 
+	modem_reset: modem-reset {
+		compatible = "gpio-reset";
+		reset-gpios = <&pca6416_2 0 GPIO_ACTIVE_LOW>;
+		reset-delay-us = <2000>;
+		reset-post-delay-ms = <40>;
+		#reset-cells = <0>;
+	};
+
+	m2_uart1_sel: fixedregulator@101 {
+		compatible = "regulator-fixed";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-name = "m2_uart1_sel";
+		gpio = <&pca6416_1 6 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+		regulator-always-on;
+	};
+
 	mux3_en: regulator-0 {
 		compatible = "regulator-fixed";
 		regulator-min-microvolt = <3300000>;
@@ -354,6 +374,27 @@  &flexcan3 {
 	status = "okay";
 };
 
+&lpuart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lpuart1>;
+	resets = <&modem_reset>;
+	status = "okay";
+
+	bluetooth {
+		compatible = "nxp,88w8987-bt";
+	};
+};
+
+&cm40_intmux {
+	status = "disabled";
+};
+
+&cm40_lpuart {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_cm40_lpuart>;
+	status = "disabled";
+};
+
 &lsio_gpio4 {
 	status = "okay";
 };
@@ -595,6 +636,15 @@  IMX8DXL_UART0_TX_ADMA_UART0_TX		0x06000020
 		>;
 	};
 
+	pinctrl_lpuart1: lpuart1grp {
+		fsl,pins = <
+			IMX8DXL_UART1_TX_ADMA_UART1_TX          0x06000020
+			IMX8DXL_UART1_RX_ADMA_UART1_RX          0x06000020
+			IMX8DXL_UART1_RTS_B_ADMA_UART1_RTS_B    0x06000020
+			IMX8DXL_UART1_CTS_B_ADMA_UART1_CTS_B    0x06000020
+		>;
+	};
+
 	pinctrl_usdhc1: usdhc1grp {
 		fsl,pins = <
 			IMX8DXL_EMMC0_CLK_CONN_EMMC0_CLK	0x06000041