| Message ID | 20240229-excluding-bonelike-d8f01dcc0623@spud (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | df620d7fabe984accf6567c846e4188fbd8add4d |
| Headers | show |
| Series | [RESEND] dt-bindings: leds: pwm-multicolour: re-allow active-low | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Thu, 29 Feb 2024, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > active-low was lifted to the common schema for leds, but it went > unnoticed that the leds-multicolour binding had "additionalProperties: > false" where the other users had "unevaluatedProperties: false", thereby > disallowing active-low for multicolour leds. Explicitly permit it again. > > Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common") > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > > This needs to go via netdev as the commit it fixes (and is based on) > is there > > CC: Pavel Machek <pavel@ucw.cz> > CC: Lee Jones <lee@kernel.org> > CC: Rob Herring <robh@kernel.org> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > CC: Conor Dooley <conor+dt@kernel.org> > CC: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > CC: Christian Marangi <ansuelsmth@gmail.com> > CC: linux-leds@vger.kernel.org > CC: devicetree@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: "David S. Miller" <davem@davemloft.net> > CC: Eric Dumazet <edumazet@google.com> > CC: Jakub Kicinski <kuba@kernel.org> > CC: Paolo Abeni <pabeni@redhat.com> > CC: netdev@vger.kernel.org > --- > Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++ > 1 file changed, 2 insertions(+) Please take this via netdev. Acked-by: Lee Jones <lee@kernel.org> > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > index 5edfbe347341..a31a202afe5c 100644 > --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > @@ -41,6 +41,8 @@ properties: > > pwm-names: true > > + active-low: true > + > color: true > > required: > -- > 2.43.0 > >
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 29 Feb 2024 18:24:00 +0000 you wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > active-low was lifted to the common schema for leds, but it went > unnoticed that the leds-multicolour binding had "additionalProperties: > false" where the other users had "unevaluatedProperties: false", thereby > disallowing active-low for multicolour leds. Explicitly permit it again. > > [...] Here is the summary with links: - [RESEND] dt-bindings: leds: pwm-multicolour: re-allow active-low https://git.kernel.org/netdev/net-next/c/df620d7fabe9 You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml index 5edfbe347341..a31a202afe5c 100644 --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml @@ -41,6 +41,8 @@ properties: pwm-names: true + active-low: true + color: true required: