| Message ID | 5d75ce122b5cbfe62b018a7719960e34cfcbb1f2.1709128975.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f29f9199c2d2b3c258f577f438885288016847ed |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] Simplify net_dbg_ratelimited() dummy | expand |
Wed, Feb 28, 2024 at 03:05:29PM CET, geert+renesas@glider.be wrote: >There is no need to wrap calls to the no_printk() helper inside an >always-false check, as no_printk() already does that internally. > >Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Wed, 28 Feb 2024 15:05:29 +0100 you wrote: > There is no need to wrap calls to the no_printk() helper inside an > always-false check, as no_printk() already does that internally. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > include/linux/net.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Here is the summary with links: - [net-next] Simplify net_dbg_ratelimited() dummy https://git.kernel.org/netdev/net-next/c/f29f9199c2d2 You are awesome, thank you!
diff --git a/include/linux/net.h b/include/linux/net.h index c9b4a63791a45948..15df6d5f27a7badc 100644 --- a/include/linux/net.h +++ b/include/linux/net.h @@ -299,10 +299,7 @@ do { \ net_ratelimited_function(pr_debug, fmt, ##__VA_ARGS__) #else #define net_dbg_ratelimited(fmt, ...) \ - do { \ - if (0) \ - no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); \ - } while (0) + no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) #endif #define net_get_random_once(buf, nbytes) \
There is no need to wrap calls to the no_printk() helper inside an always-false check, as no_printk() already does that internally. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- include/linux/net.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)