| Message ID | 20240229170956.87290-1-kerneljasonxing@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add two missing addresses when using trace | expand |
On Fri, Mar 1, 2024 at 1:10 AM Jason Xing <kerneljasonxing@gmail.com> wrote: > > From: Jason Xing <kernelxing@tencent.com> > > When I reviewed other people's patch [1], I noticed that similar thing > also happens in tcp_event_skb class and tcp_event_sk_skb class. They > don't print those two addrs of skb/sk which already exist. > > They are probably forgotten by the original authors, so this time I > finish the work. Also, adding more trace about the socket/skb addr can > help us sometime even though the chance is minor. > > I don't consider it is a bug, thus I chose to target net-next tree. Gentle ping...No rush. Just in case this simple patchset was lost for some reason. Thanks, Jason > > [1] > Link: https://lore.kernel.org/netdev/CAL+tcoAhvFhXdr1WQU8mv_6ZX5nOoNpbOLAB6=C+DB-qXQ11Ew@mail.gmail.com/ > > Jason Xing (2): > tcp: add tracing of skb/skaddr in tcp_event_sk_skb class > tcp: add tracing of skbaddr in tcp_event_skb class > > include/trace/events/tcp.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > -- > 2.37.3 >
On Mon, Mar 4, 2024 at 8:01 AM Jason Xing <kerneljasonxing@gmail.com> wrote: > > On Fri, Mar 1, 2024 at 1:10 AM Jason Xing <kerneljasonxing@gmail.com> wrote: > > > > From: Jason Xing <kernelxing@tencent.com> > > > > When I reviewed other people's patch [1], I noticed that similar thing > > also happens in tcp_event_skb class and tcp_event_sk_skb class. They > > don't print those two addrs of skb/sk which already exist. > > > > They are probably forgotten by the original authors, so this time I > > finish the work. Also, adding more trace about the socket/skb addr can > > help us sometime even though the chance is minor. > > > > I don't consider it is a bug, thus I chose to target net-next tree. > > Gentle ping...No rush. Just in case this simple patchset was lost for > some reason. This was a conscious choice I think. https://yhbt.net/lore/all/20171010173821.6djxyvrggvaivqec@ast-mbp.dhcp.thefacebook.com/
From: Jason Xing <kernelxing@tencent.com> When I reviewed other people's patch [1], I noticed that similar thing also happens in tcp_event_skb class and tcp_event_sk_skb class. They don't print those two addrs of skb/sk which already exist. They are probably forgotten by the original authors, so this time I finish the work. Also, adding more trace about the socket/skb addr can help us sometime even though the chance is minor. I don't consider it is a bug, thus I chose to target net-next tree. [1] Link: https://lore.kernel.org/netdev/CAL+tcoAhvFhXdr1WQU8mv_6ZX5nOoNpbOLAB6=C+DB-qXQ11Ew@mail.gmail.com/ Jason Xing (2): tcp: add tracing of skb/skaddr in tcp_event_sk_skb class tcp: add tracing of skbaddr in tcp_event_skb class include/trace/events/tcp.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)