| Message ID | 20240221-pm4125-typec-v3-2-fdd0ee0465b8@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: qrb2210-rb1: enable Type-C support | expand |
On Wed, 21 Feb 2024 at 01:58, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > The PM4125 PMIC has the same Type-C register block as the PMI632. > Likewise it doesn't support USB Power Delivery. Define the compatible > for the TypeC block found on PM4125, using PMI632 as a compatible. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Making a fool of me, for v2 there was: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > index 6c0c6b337693..5527a4bc9388 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > @@ -14,9 +14,15 @@ description: > > properties: > compatible: > - enum: > - - qcom,pmi632-typec > - - qcom,pm8150b-typec > + oneOf: > + - enum: > + - qcom,pmi632-typec > + - qcom,pm8150b-typec > + - items: > + - enum: > + - qcom,pm4125-typec > + - const: qcom,pmi632-typec > + > > connector: > type: object > > -- > 2.39.2 >
On Wed, 21 Feb 2024 at 02:00, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Wed, 21 Feb 2024 at 01:58, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > The PM4125 PMIC has the same Type-C register block as the PMI632. > > Likewise it doesn't support USB Power Delivery. Define the compatible > > for the TypeC block found on PM4125, using PMI632 as a compatible. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Making a fool of me, for v2 there was: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Greg, as Mark has picked up the vbus regulator patch, is there a chance of you picking up this patch? > > > --- > > Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > > index 6c0c6b337693..5527a4bc9388 100644 > > --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > > +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > > @@ -14,9 +14,15 @@ description: > > > > properties: > > compatible: > > - enum: > > - - qcom,pmi632-typec > > - - qcom,pm8150b-typec > > + oneOf: > > + - enum: > > + - qcom,pmi632-typec > > + - qcom,pm8150b-typec > > + - items: > > + - enum: > > + - qcom,pm4125-typec > > + - const: qcom,pmi632-typec > > + > > > > connector: > > type: object > > > > -- > > 2.39.2 > > > > > -- > With best wishes > Dmitry
On Mon, Mar 04, 2024 at 02:08:19AM +0200, Dmitry Baryshkov wrote: > On Wed, 21 Feb 2024 at 02:00, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > On Wed, 21 Feb 2024 at 01:58, Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > > > > > > The PM4125 PMIC has the same Type-C register block as the PMI632. > > > Likewise it doesn't support USB Power Delivery. Define the compatible > > > for the TypeC block found on PM4125, using PMI632 as a compatible. > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Making a fool of me, for v2 there was: > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Greg, as Mark has picked up the vbus regulator patch, is there a > chance of you picking up this patch? As it doesn't apply to my usb-next branch, it's hard to do so :( Can you rebase it against there and resend? thanks, greg k-h
On Mon, 4 Mar 2024 at 10:32, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Mar 04, 2024 at 02:08:19AM +0200, Dmitry Baryshkov wrote: > > On Wed, 21 Feb 2024 at 02:00, Dmitry Baryshkov > > <dmitry.baryshkov@linaro.org> wrote: > > > > > > On Wed, 21 Feb 2024 at 01:58, Dmitry Baryshkov > > > <dmitry.baryshkov@linaro.org> wrote: > > > > > > > > The PM4125 PMIC has the same Type-C register block as the PMI632. > > > > Likewise it doesn't support USB Power Delivery. Define the compatible > > > > for the TypeC block found on PM4125, using PMI632 as a compatible. > > > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > > > Making a fool of me, for v2 there was: > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Greg, as Mark has picked up the vbus regulator patch, is there a > > chance of you picking up this patch? > > As it doesn't apply to my usb-next branch, it's hard to do so :( > > Can you rebase it against there and resend? Done, thank you. > > thanks, > > greg k-h
diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml index 6c0c6b337693..5527a4bc9388 100644 --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml @@ -14,9 +14,15 @@ description: properties: compatible: - enum: - - qcom,pmi632-typec - - qcom,pm8150b-typec + oneOf: + - enum: + - qcom,pmi632-typec + - qcom,pm8150b-typec + - items: + - enum: + - qcom,pm4125-typec + - const: qcom,pmi632-typec + connector: type: object
The PM4125 PMIC has the same Type-C register block as the PMI632. Likewise it doesn't support USB Power Delivery. Define the compatible for the TypeC block found on PM4125, using PMI632 as a compatible. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)