Message ID | 20240303114139.GA11018@didi-ThinkCentre-M920t-N000 (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net-next,v2] net/nlmon: Cancel setting the fields of statistics to zero. | expand |
On Sun, Mar 3, 2024 at 12:42 PM fuyuanli <fuyuanli@didiglobal.com> wrote: > > Since fields of rtnl_link_stats64 have been set to zero in the previous > dev_get_stats function, there is no need to set them again in the > ndo_get_stats64 function. > > Signed-off-by: fuyuanli <fuyuanli@didiglobal.com> > Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-ThinkCentre-M920t-N000/ > Reviewed-by: Eric Dumazet <edumazet@google.com>
On Sun, Mar 3, 2024 at 7:43 PM fuyuanli <fuyuanli@didiglobal.com> wrote: > > Since fields of rtnl_link_stats64 have been set to zero in the previous > dev_get_stats function, there is no need to set them again in the > ndo_get_stats64 function. > > Signed-off-by: fuyuanli <fuyuanli@didiglobal.com> > Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-ThinkCentre-M920t-N000/ Suggested-by: Jason Xing <kerneljasonxing@gmail.com> See https://lore.kernel.org/all/CAL+tcoA=FVBJi2eJgAELhWG_f+N-kwmrHc+XRfKXhYk2RJcPKg@mail.gmail.com/ Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Jason Xing <kerneljasonxing@gmail.com> 于2024年3月4日周一 15:05写道: > > On Sun, Mar 3, 2024 at 7:43 PM fuyuanli <fuyuanli@didiglobal.com> wrote: > > > > Since fields of rtnl_link_stats64 have been set to zero in the previous > > dev_get_stats function, there is no need to set them again in the > > ndo_get_stats64 function. > > > > Signed-off-by: fuyuanli <fuyuanli@didiglobal.com> > > Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-ThinkCentre-M920t-N000/ > > Suggested-by: Jason Xing <kerneljasonxing@gmail.com> > See https://lore.kernel.org/all/CAL+tcoA=FVBJi2eJgAELhWG_f+N-kwmrHc+XRfKXhYk2RJcPKg@mail.gmail.com/ OK, I will submit a v3 patch which updating commit message, thanks. > > Reviewed-by: Jason Xing <kerneljasonxing@gmail.com> >
On Mon, Mar 4, 2024 at 7:14 PM yuanli fu <fuyuanli0722@gmail.com> wrote: > > Jason Xing <kerneljasonxing@gmail.com> 于2024年3月4日周一 15:05写道: > > > > On Sun, Mar 3, 2024 at 7:43 PM fuyuanli <fuyuanli@didiglobal.com> wrote: > > > > > > Since fields of rtnl_link_stats64 have been set to zero in the previous > > > dev_get_stats function, there is no need to set them again in the > > > ndo_get_stats64 function. > > > > > > Signed-off-by: fuyuanli <fuyuanli@didiglobal.com> > > > Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-ThinkCentre-M920t-N000/ > > > > Suggested-by: Jason Xing <kerneljasonxing@gmail.com> > > See https://lore.kernel.org/all/CAL+tcoA=FVBJi2eJgAELhWG_f+N-kwmrHc+XRfKXhYk2RJcPKg@mail.gmail.com/ > OK, I will submit a v3 patch which updating commit message, thanks. I don't think you need to send a new version of the patch unless someone points out other changes that should be made. Thanks, Jason > > > > Reviewed-by: Jason Xing <kerneljasonxing@gmail.com> > >
On 3/4/24 2:25 PM, Jason Xing wrote: > On Mon, Mar 4, 2024 at 7:14 PM yuanli fu <fuyuanli0722@gmail.com> wrote: >> Jason Xing <kerneljasonxing@gmail.com> 于2024年3月4日周一 15:05写道: >>> On Sun, Mar 3, 2024 at 7:43 PM fuyuanli <fuyuanli@didiglobal.com> wrote: >>>> >>>> Since fields of rtnl_link_stats64 have been set to zero in the previous >>>> dev_get_stats function, there is no need to set them again in the >>>> ndo_get_stats64 function. >>>> >>>> Signed-off-by: fuyuanli <fuyuanli@didiglobal.com> >>>> Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-ThinkCentre-M920t-N000/ >>> >>> Suggested-by: Jason Xing <kerneljasonxing@gmail.com> >>> See https://lore.kernel.org/all/CAL+tcoA=FVBJi2eJgAELhWG_f+N-kwmrHc+XRfKXhYk2RJcPKg@mail.gmail.com/ >> OK, I will submit a v3 patch which updating commit message, thanks. > > I don't think you need to send a new version of the patch unless > someone points out other changes that should be made. I think this patch is not needed anymore, see net-next : 4f41ce81a919 ("net: nlmon: Remove init and uninit functions") 26b5df99bf60 ("net: nlmon: Simplify nlmon_get_stats64") Thanks, Daniel
diff --git a/drivers/net/nlmon.c b/drivers/net/nlmon.c index 5e19a6839dea..9b205b152734 100644 --- a/drivers/net/nlmon.c +++ b/drivers/net/nlmon.c @@ -56,10 +56,8 @@ nlmon_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats) dev_lstats_read(dev, &packets, &bytes); stats->rx_packets = packets; - stats->tx_packets = 0; stats->rx_bytes = bytes; - stats->tx_bytes = 0; } static u32 always_on(struct net_device *dev)
Since fields of rtnl_link_stats64 have been set to zero in the previous dev_get_stats function, there is no need to set them again in the ndo_get_stats64 function. Signed-off-by: fuyuanli <fuyuanli@didiglobal.com> Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-ThinkCentre-M920t-N000/ --- v2: 1) check and fix error of spelling and grammar in the commit message. --- drivers/net/nlmon.c | 2 -- 1 file changed, 2 deletions(-)