[1/5] qmimodem: Use stdbool instead of gboolean

Commit Message

Denis Kenzior March 4, 2024, 8:34 p.m. UTC

---
 drivers/qmimodem/sim-legacy.c |  4 ++--
 drivers/qmimodem/sim.c        | 16 ++++++++--------
 2 files changed, 10 insertions(+), 10 deletions(-)

Comments

[e-mail] March 4, 2024, 10 p.m. UTC | #1

Hello:

This series was applied to ofono.git (master)
by Denis Kenzior <[e-mail]>:

On Mon,  4 Mar 2024 14:34:49 -0600 you wrote:
> ---
>  drivers/qmimodem/sim-legacy.c |  4 ++--
>  drivers/qmimodem/sim.c        | 16 ++++++++--------
>  2 files changed, 10 insertions(+), 10 deletions(-)

Here is the summary with links:
  - [1/5] qmimodem: Use stdbool instead of gboolean
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=2e707f79d546
  - [2/5] qmimodem: Use ell endianness converter helpers
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=f4b626316d3e
  - [3/5] qmimodem: Use l_new / l_free
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=588ea1013417
  - [4/5] gobi: Replace g_try_new0 / g_free with ell equivalents
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=9eb530b94110
  - [5/5] qmimodem: Remove glib use from util.[ch]
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=5f669d82f73c

You are awesome, thank you!

Patch

diff --git a/drivers/qmimodem/sim-legacy.c b/drivers/qmimodem/sim-legacy.c
index cb4ad0646037..12e5ab079111 100644
--- a/drivers/qmimodem/sim-legacy.c
+++ b/drivers/qmimodem/sim-legacy.c
@@ -250,13 +250,13 @@  static void process_uim_state(struct ofono_sim *sim, uint8_t state)
 
 	switch (state) {
 	case QMI_DMS_UIM_STATE_INIT_COMPLETE:
-		ofono_sim_inserted_notify(sim, TRUE);
+		ofono_sim_inserted_notify(sim, true);
 		ofono_sim_initialized_notify(sim);
 		break;
 	case QMI_DMS_UIM_STATE_INIT_FAILED:
 	case QMI_DMS_UIM_STATE_NOT_PRESENT:
 	case QMI_DMS_UIM_STATE_INVALID:
-		ofono_sim_inserted_notify(sim, FALSE);
+		ofono_sim_inserted_notify(sim, false);
 		break;
 	}
 }
diff --git a/drivers/qmimodem/sim.c b/drivers/qmimodem/sim.c
index 625846c5efd9..0b73b3c7598b 100644
--- a/drivers/qmimodem/sim.c
+++ b/drivers/qmimodem/sim.c
@@ -121,7 +121,7 @@  static void get_file_attributes_cb(struct qmi_result *result, void *user_data)
 	int flen, rlen, str;
 	unsigned char access[3];
 	unsigned char file_status;
-	gboolean ok;
+	bool ok;
 
 	DBG("");
 
@@ -146,7 +146,7 @@  static void get_file_attributes_cb(struct qmi_result *result, void *user_data)
 		file_status = EF_STATUS_VALID;
 		break;
 	default:
-		ok = FALSE;
+		ok = false;
 		break;
 	}
 
@@ -608,7 +608,7 @@  static void query_passwd_state_cb(struct qmi_result *result,
 		data->retry_count = 0;
 		if (sim_stat.passwd_state == OFONO_SIM_PASSWORD_INVALID) {
 			CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-			ofono_sim_inserted_notify(sim, FALSE);
+			ofono_sim_inserted_notify(sim, false);
 		} else
 			CALLBACK_WITH_SUCCESS(cb, sim_stat.passwd_state,
 								cbd->data);
@@ -621,7 +621,7 @@  static void query_passwd_state_cb(struct qmi_result *result,
 							sim_stat.card_state);
 			data->retry_count = 0;
 			CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-			ofono_sim_inserted_notify(sim, FALSE);
+			ofono_sim_inserted_notify(sim, false);
 		} else {
 			DBG("Retry command");
 			retry_cbd = cb_data_new(cb, cbd->data);
@@ -635,7 +635,7 @@  static void query_passwd_state_cb(struct qmi_result *result,
 		DBG("Command failed");
 		data->retry_count = 0;
 		CALLBACK_WITH_FAILURE(cb, -1, cbd->data);
-		ofono_sim_inserted_notify(sim, FALSE);
+		ofono_sim_inserted_notify(sim, false);
 		break;
 	}
 }
@@ -781,7 +781,7 @@  static void get_card_status_cb(struct qmi_result *result, void *user_data)
 	case 0x02:	/* Error */
 		break;
 	case 0x01:	/* Present */
-		ofono_sim_inserted_notify(sim, TRUE);
+		ofono_sim_inserted_notify(sim, true);
 		ofono_sim_initialized_notify(sim);
 		break;
 	}
@@ -806,10 +806,10 @@  static void card_status_notify(struct qmi_result *result, void *user_data)
 	switch (sim_stat.card_state) {
 	case 0x00:	/* Absent */
 	case 0x02:	/* Error */
-		ofono_sim_inserted_notify(sim, FALSE);
+		ofono_sim_inserted_notify(sim, false);
 		break;
 	case 0x01:	/* Present */
-		ofono_sim_inserted_notify(sim, TRUE);
+		ofono_sim_inserted_notify(sim, true);
 		break;
 	}
 }