[blktests,v2,0/2] make nvme/048 checks more robust

Message

Daniel Wagner March 4, 2024, 1:48 p.m. UTC

The nvme/048 tests fails with the fc transport because the check logic is racing
with the reset code in the target. By making the checks a bit more robust in
blktests, this test passes for all transports.

changes
v2:
  - added RB tags
  - refactored exit path as suggested by Shinichiro
v1:
  - initial version
  - https://lore.kernel.org/linux-nvme/[e-mail]/

*** BLURB HERE ***

Daniel Wagner (2):
  nvme/048: remove unused argument for set_qid_max
  nvme/048: make queue count check retry-able

 tests/nvme/048 | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

Comments

Shin'ichiro Kawasaki March 5, 2024, 1:29 a.m. UTC | #1

On Mar 04, 2024 / 14:48, Daniel Wagner wrote:
> The nvme/048 tests fails with the fc transport because the check logic is racing
> with the reset code in the target. By making the checks a bit more robust in
> blktests, this test passes for all transports.
> 
> changes
> v2:
>   - added RB tags
>   - refactored exit path as suggested by Shinichiro
> v1:
>   - initial version
>   - https://lore.kernel.org/linux-nvme/[e-mail]/

Thanks for this v2 series. I've applied the two patches.

Of note is that I removed the left if block in nvmf_check_queue_count(), which I
believe unnecessary.

Daniel Wagner March 5, 2024, 7:20 a.m. UTC | #2

On Tue, Mar 05, 2024 at 01:29:18AM +0000, Shinichiro Kawasaki wrote:
> Of note is that I removed the left if block in nvmf_check_queue_count(), which I
> believe unnecessary.

This was also what I did. But somehow I managed to send out the wrong
version. Thanks for fixing it!