| Message ID | 20240228-net-v6-10-6d78d3d598c1@outlook.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles | expand |
On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > It's hard to get the version number for each FEMAC core and it's unknown > how the version can be used. Remove them until it's really needed. > > Signed-off-by: Yang Xiwen <forbidden405@outlook.com> > --- > drivers/net/ethernet/hisilicon/hisi_femac.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c > index 2406263c9dd3..3c5c095dad05 100644 > --- a/drivers/net/ethernet/hisilicon/hisi_femac.c > +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c > @@ -945,8 +945,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev) > #endif > > static const struct of_device_id hisi_femac_match[] = { > - {.compatible = "hisilicon,hisi-femac-v1",}, > - {.compatible = "hisilicon,hisi-femac-v2",}, > + {.compatible = "hisilicon,hisi-femac",}, Drop and just use SoC compatibles. > {.compatible = "hisilicon,hi3516cv300-femac",}, Best regards, Krzysztof
On 2/29/2024 4:07 PM, Krzysztof Kozlowski wrote: > On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote: >> From: Yang Xiwen <forbidden405@outlook.com> >> >> It's hard to get the version number for each FEMAC core and it's unknown >> how the version can be used. Remove them until it's really needed. >> >> Signed-off-by: Yang Xiwen <forbidden405@outlook.com> >> --- >> drivers/net/ethernet/hisilicon/hisi_femac.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c >> index 2406263c9dd3..3c5c095dad05 100644 >> --- a/drivers/net/ethernet/hisilicon/hisi_femac.c >> +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c >> @@ -945,8 +945,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev) >> #endif >> >> static const struct of_device_id hisi_femac_match[] = { >> - {.compatible = "hisilicon,hisi-femac-v1",}, >> - {.compatible = "hisilicon,hisi-femac-v2",}, >> + {.compatible = "hisilicon,hisi-femac",}, > Drop and just use SoC compatibles. Will be fixed in v8. > >> {.compatible = "hisilicon,hi3516cv300-femac",}, > > > Best regards, > Krzysztof >
diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c index 2406263c9dd3..3c5c095dad05 100644 --- a/drivers/net/ethernet/hisilicon/hisi_femac.c +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c @@ -945,8 +945,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev) #endif static const struct of_device_id hisi_femac_match[] = { - {.compatible = "hisilicon,hisi-femac-v1",}, - {.compatible = "hisilicon,hisi-femac-v2",}, + {.compatible = "hisilicon,hisi-femac",}, {.compatible = "hisilicon,hi3516cv300-femac",}, {}, };