| Message ID | 20240301-for-netnext-mt7530-improvements-3-v3-0-449f4f166454@arinc9.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | MT7530 DSA Subdriver Improvements Act III | expand |
On Fri, 2024-03-01 at 12:42 +0200, Arınç ÜNAL wrote: > This is the third patch series with the goal of simplifying the MT7530 DSA > subdriver and improving support for MT7530, MT7531, and the switch on the > MT7988 SoC. > > I have done a simple ping test to confirm basic communication on all switch > ports on MCM and standalone MT7530, and MT7531 switch with this patch > series applied. > > MT7621 Unielec, MCM MT7530: > > rgmii-only-gmac0-mt7621-unielec-u7621-06-16m.dtb > gmac0-and-gmac1-mt7621-unielec-u7621-06-16m.dtb > > tftpboot 0x80008000 mips-uzImage.bin; tftpboot 0x83000000 mips-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootm 0x80008000 0x83000000 0x83f00000 > > MT7622 Bananapi, MT7531: > > gmac0-and-gmac1-mt7622-bananapi-bpi-r64.dtb > > tftpboot 0x40000000 arm64-Image; tftpboot 0x45000000 arm64-rootfs.cpio.uboot; tftpboot 0x4a000000 $dtb; booti 0x40000000 0x45000000 0x4a000000 > > MT7623 Bananapi, standalone MT7530: > > rgmii-only-gmac0-mt7623n-bananapi-bpi-r2.dtb > gmac0-and-gmac1-mt7623n-bananapi-bpi-r2.dtb > > tftpboot 0x80008000 arm-zImage; tftpboot 0x83000000 arm-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootz 0x80008000 0x83000000 0x83f00000 > > This patch series is the continuation of the patch series linked below. > > https://lore.kernel.org/r/20230522121532.86610-1-arinc.unal@arinc9.com > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> @Russell, I see you went through some patches; my understanding is that there are no objection to this series in the current form. The series LGTM, so I'm going to apply it: I think it would a pity if it should miss this cycle. Cheers, Paolo
On Tue, Mar 05, 2024 at 12:30:20PM +0100, Paolo Abeni wrote: > On Fri, 2024-03-01 at 12:42 +0200, Arınç ÜNAL wrote: > > This is the third patch series with the goal of simplifying the MT7530 DSA > > subdriver and improving support for MT7530, MT7531, and the switch on the > > MT7988 SoC. > > > > I have done a simple ping test to confirm basic communication on all switch > > ports on MCM and standalone MT7530, and MT7531 switch with this patch > > series applied. > > > > MT7621 Unielec, MCM MT7530: > > > > rgmii-only-gmac0-mt7621-unielec-u7621-06-16m.dtb > > gmac0-and-gmac1-mt7621-unielec-u7621-06-16m.dtb > > > > tftpboot 0x80008000 mips-uzImage.bin; tftpboot 0x83000000 mips-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootm 0x80008000 0x83000000 0x83f00000 > > > > MT7622 Bananapi, MT7531: > > > > gmac0-and-gmac1-mt7622-bananapi-bpi-r64.dtb > > > > tftpboot 0x40000000 arm64-Image; tftpboot 0x45000000 arm64-rootfs.cpio.uboot; tftpboot 0x4a000000 $dtb; booti 0x40000000 0x45000000 0x4a000000 > > > > MT7623 Bananapi, standalone MT7530: > > > > rgmii-only-gmac0-mt7623n-bananapi-bpi-r2.dtb > > gmac0-and-gmac1-mt7623n-bananapi-bpi-r2.dtb > > > > tftpboot 0x80008000 arm-zImage; tftpboot 0x83000000 arm-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootz 0x80008000 0x83000000 0x83f00000 > > > > This patch series is the continuation of the patch series linked below. > > > > https://lore.kernel.org/r/20230522121532.86610-1-arinc.unal@arinc9.com > > > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > @Russell, I see you went through some patches; my understanding is that > there are no objection to this series in the current form. The series > LGTM, so I'm going to apply it: I think it would a pity if it should > miss this cycle. That's fine - I did read through the entire series, but only gave my r-b on the ones I felt I'd done a good enough job on. You may have noticed I haven't submitted much network stuff this cycle... I have limited bandwidth at the moment.
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Fri, 01 Mar 2024 12:42:56 +0200 you wrote: > Hello! > > This is the third patch series with the goal of simplifying the MT7530 DSA > subdriver and improving support for MT7530, MT7531, and the switch on the > MT7988 SoC. > > I have done a simple ping test to confirm basic communication on all switch > ports on MCM and standalone MT7530, and MT7531 switch with this patch > series applied. > > [...] Here is the summary with links: - [net-next,v3,1/9] net: dsa: mt7530: remove .mac_port_config for MT7988 and make it optional https://git.kernel.org/netdev/net-next/c/6ebe414b48cf - [net-next,v3,2/9] net: dsa: mt7530: set interrupt register only for MT7530 https://git.kernel.org/netdev/net-next/c/804cd5f7059e - [net-next,v3,3/9] net: dsa: mt7530: do not use SW_PHY_RST to reset MT7531 switch https://git.kernel.org/netdev/net-next/c/a565f98d7d25 - [net-next,v3,4/9] net: dsa: mt7530: get rid of useless error returns on phylink code path https://git.kernel.org/netdev/net-next/c/adf4ae24ba42 - [net-next,v3,5/9] net: dsa: mt7530: get rid of priv->info->cpu_port_config() https://git.kernel.org/netdev/net-next/c/22fa10170af5 - [net-next,v3,6/9] net: dsa: mt7530: get rid of mt753x_mac_config() https://git.kernel.org/netdev/net-next/c/1192ed898c97 - [net-next,v3,7/9] net: dsa: mt7530: put initialising PCS devices code back to original order https://git.kernel.org/netdev/net-next/c/3a87131e3d72 - [net-next,v3,8/9] net: dsa: mt7530: sort link settings ops and force link down on all ports https://git.kernel.org/netdev/net-next/c/6324230b3b67 - [net-next,v3,9/9] net: dsa: mt7530: simplify link operations https://git.kernel.org/netdev/net-next/c/b04097c7a745 You are awesome, thank you!
Hello! This is the third patch series with the goal of simplifying the MT7530 DSA subdriver and improving support for MT7530, MT7531, and the switch on the MT7988 SoC. I have done a simple ping test to confirm basic communication on all switch ports on MCM and standalone MT7530, and MT7531 switch with this patch series applied. MT7621 Unielec, MCM MT7530: rgmii-only-gmac0-mt7621-unielec-u7621-06-16m.dtb gmac0-and-gmac1-mt7621-unielec-u7621-06-16m.dtb tftpboot 0x80008000 mips-uzImage.bin; tftpboot 0x83000000 mips-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootm 0x80008000 0x83000000 0x83f00000 MT7622 Bananapi, MT7531: gmac0-and-gmac1-mt7622-bananapi-bpi-r64.dtb tftpboot 0x40000000 arm64-Image; tftpboot 0x45000000 arm64-rootfs.cpio.uboot; tftpboot 0x4a000000 $dtb; booti 0x40000000 0x45000000 0x4a000000 MT7623 Bananapi, standalone MT7530: rgmii-only-gmac0-mt7623n-bananapi-bpi-r2.dtb gmac0-and-gmac1-mt7623n-bananapi-bpi-r2.dtb tftpboot 0x80008000 arm-zImage; tftpboot 0x83000000 arm-rootfs.cpio.uboot; tftpboot 0x83f00000 $dtb; bootz 0x80008000 0x83000000 0x83f00000 This patch series is the continuation of the patch series linked below. https://lore.kernel.org/r/20230522121532.86610-1-arinc.unal@arinc9.com Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- Changes in v3: - Patch 8 - Explain properly the behaviour of setting link down on all ports at setup. - Split the changes for simplifying the link settings operations out to another patch. - Link to v2: https://lore.kernel.org/r/20240216-for-netnext-mt7530-improvements-3-v2-0-094cae3ff23b@arinc9.com Changes in v2: - Patch 8 - Use a single mt7530_rmw() instead of two mt7530_clear() and mt7530_set() commands. - Link to v1: https://lore.kernel.org/r/20240208-for-netnext-mt7530-improvements-3-v1-0-d7c1cfd502ca@arinc9.com --- Arınç ÜNAL (9): net: dsa: mt7530: remove .mac_port_config for MT7988 and make it optional net: dsa: mt7530: set interrupt register only for MT7530 net: dsa: mt7530: do not use SW_PHY_RST to reset MT7531 switch net: dsa: mt7530: get rid of useless error returns on phylink code path net: dsa: mt7530: get rid of priv->info->cpu_port_config() net: dsa: mt7530: get rid of mt753x_mac_config() net: dsa: mt7530: put initialising PCS devices code back to original order net: dsa: mt7530: sort link settings ops and force link down on all ports net: dsa: mt7530: simplify link operations drivers/net/dsa/mt7530.c | 259 ++++++++--------------------------------------- drivers/net/dsa/mt7530.h | 19 +--- 2 files changed, 47 insertions(+), 231 deletions(-) --- base-commit: b6b614558ed5b2ca50edacc0f2fbf5f52158c86c change-id: 20240131-for-netnext-mt7530-improvements-3-a8ac49d4f7c2 Best regards,