diff mbox series

staging: sm750fb: rename function deGetTransparency()

Message ID ZdiyhAwNTPmbS3E0@Wayne (mailing list archive)
State Handled Elsewhere
Headers show
Series staging: sm750fb: rename function deGetTransparency() | expand

Commit Message

Samuel Kayode Feb. 23, 2024, 2:58 p.m. UTC
Rename function deGetTransparency to de_get_transparency to fix
checkpatch warning Avoid CamelCase.

Signed-off-by: Samuel Kayode <samkay014@gmail.com>
---
 drivers/staging/sm750fb/sm750_accel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Greg Kroah-Hartman March 5, 2024, 2:01 p.m. UTC | #1
On Fri, Feb 23, 2024 at 10:58:12AM -0400, Samuel Kayode wrote:
> Rename function deGetTransparency to de_get_transparency to fix
> checkpatch warning Avoid CamelCase.
> 
> Signed-off-by: Samuel Kayode <samkay014@gmail.com>
> ---
>  drivers/staging/sm750fb/sm750_accel.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 44b9e3fe3a41..ad9d8bd34e5a 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -284,7 +284,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
>  	return 0;
>  }
>  
> -static unsigned int deGetTransparency(struct lynx_accel *accel)
> +static unsigned int de_get_transparency(struct lynx_accel *accel)

What does "de_" here mean?  Why did you keep it?

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 44b9e3fe3a41..ad9d8bd34e5a 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -284,7 +284,7 @@  int sm750_hw_copyarea(struct lynx_accel *accel,
 	return 0;
 }
 
-static unsigned int deGetTransparency(struct lynx_accel *accel)
+static unsigned int de_get_transparency(struct lynx_accel *accel)
 {
 	unsigned int de_ctrl;
 
@@ -391,7 +391,7 @@  int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf,
 		DE_CONTROL_ROP_SELECT | DE_CONTROL_COMMAND_HOST_WRITE |
 		DE_CONTROL_HOST | DE_CONTROL_STATUS;
 
-	write_dpr(accel, DE_CONTROL, de_ctrl | deGetTransparency(accel));
+	write_dpr(accel, DE_CONTROL, de_ctrl | de_get_transparency(accel));
 
 	/* Write MONO data (line by line) to 2D Engine data port */
 	for (i = 0; i < height; i++) {