mbox series

[net-next,0/6] selftests: forwarding: Various improvements

Message ID 20240304095612.462900-1-idosch@nvidia.com (mailing list archive)
Headers show
Series selftests: forwarding: Various improvements | expand

Message

Ido Schimmel March 4, 2024, 9:56 a.m. UTC
This patchset speeds up the multipath tests (patches #1-#2) and makes
other tests more stable (patches #3-#6) so that they will not randomly
fail in the netdev CI.

On my system, after applying the first two patches, the run time of
gre_multipath_nh_res.sh is reduced by over 90%.

Ido Schimmel (6):
  selftests: forwarding: Remove IPv6 L3 multipath hash tests
  selftests: forwarding: Parametrize mausezahn delay
  selftests: forwarding: Make tc-police pass on debug kernels
  selftests: forwarding: Make vxlan-bridge-1q pass on debug kernels
  selftests: forwarding: Make VXLAN ECN encap tests more robust
  selftests: forwarding: Make {, ip6}gre-inner-v6-multipath tests more
    robust

 .../net/forwarding/custom_multipath_hash.sh   | 16 +++----
 .../net/forwarding/forwarding.config.sample   |  2 +
 .../forwarding/gre_custom_multipath_hash.sh   | 16 +++----
 .../net/forwarding/gre_inner_v4_multipath.sh  |  2 +-
 .../net/forwarding/gre_inner_v6_multipath.sh  |  6 +--
 .../selftests/net/forwarding/gre_multipath.sh |  2 +-
 .../net/forwarding/gre_multipath_nh.sh        | 41 +-----------------
 .../net/forwarding/gre_multipath_nh_res.sh    | 42 +-----------------
 .../ip6gre_custom_multipath_hash.sh           | 16 +++----
 .../forwarding/ip6gre_inner_v4_multipath.sh   |  2 +-
 .../forwarding/ip6gre_inner_v6_multipath.sh   |  6 +--
 .../selftests/net/forwarding/ip6gre_lib.sh    |  4 +-
 tools/testing/selftests/net/forwarding/lib.sh |  1 +
 .../net/forwarding/router_mpath_nh.sh         | 39 ++---------------
 .../net/forwarding/router_mpath_nh_res.sh     |  4 +-
 .../net/forwarding/router_multipath.sh        | 43 ++-----------------
 .../selftests/net/forwarding/tc_police.sh     | 16 +++----
 .../net/forwarding/vxlan_bridge_1d.sh         |  4 +-
 .../net/forwarding/vxlan_bridge_1d_ipv6.sh    |  4 +-
 .../net/forwarding/vxlan_bridge_1q.sh         | 10 ++---
 20 files changed, 67 insertions(+), 209 deletions(-)

Comments

Jakub Kicinski March 4, 2024, 2:43 p.m. UTC | #1
On Mon, 4 Mar 2024 11:56:06 +0200 Ido Schimmel wrote:
> This patchset speeds up the multipath tests (patches #1-#2) and makes
> other tests more stable (patches #3-#6) so that they will not randomly
> fail in the netdev CI.
> 
> On my system, after applying the first two patches, the run time of
> gre_multipath_nh_res.sh is reduced by over 90%.

Great stuff! On the debug runner the total runtime for
gre-multipath-nh-res goes from 10016 sec (and timeout)
to 105sec! The overall runtime for the suite cut from 3h
to 1h31min. With 6 extra passes. I'll remove vxlan_bridge_1d.sh
from filtered once we merge.

Acked-by: Jakub Kicinski <kuba@kernel.org>

Thank you!
patchwork-bot+netdevbpf@kernel.org March 5, 2024, 6:40 p.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 4 Mar 2024 11:56:06 +0200 you wrote:
> This patchset speeds up the multipath tests (patches #1-#2) and makes
> other tests more stable (patches #3-#6) so that they will not randomly
> fail in the netdev CI.
> 
> On my system, after applying the first two patches, the run time of
> gre_multipath_nh_res.sh is reduced by over 90%.
> 
> [...]

Here is the summary with links:
  - [net-next,1/6] selftests: forwarding: Remove IPv6 L3 multipath hash tests
    https://git.kernel.org/netdev/net-next/c/7b2d64f93319
  - [net-next,2/6] selftests: forwarding: Parametrize mausezahn delay
    https://git.kernel.org/netdev/net-next/c/748d27447daa
  - [net-next,3/6] selftests: forwarding: Make tc-police pass on debug kernels
    https://git.kernel.org/netdev/net-next/c/4aca9eae6f7b
  - [net-next,4/6] selftests: forwarding: Make vxlan-bridge-1q pass on debug kernels
    https://git.kernel.org/netdev/net-next/c/dfbab74044be
  - [net-next,5/6] selftests: forwarding: Make VXLAN ECN encap tests more robust
    https://git.kernel.org/netdev/net-next/c/f0008b04977a
  - [net-next,6/6] selftests: forwarding: Make {, ip6}gre-inner-v6-multipath tests more robust
    https://git.kernel.org/netdev/net-next/c/35df2ce896dc

You are awesome, thank you!