| Message ID | 20240121-sm7125-upstream-v4-2-f7d1212c8ebb@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add UFS support for SC7180/SM7125 | expand |
On Sun, Jan 21, 2024 at 05:57:42PM +0100, David Wronek wrote: > Document the compatible for the UFS found on SC7180. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: David Wronek <davidwronek@gmail.com> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > 1 file changed, 2 insertions(+) Should have been picked up by SCSI/UFS maintainers, but it hasn't, so I applied it. Rob
On Tue, 13 Feb 2024 at 00:22, Rob Herring <robh@kernel.org> wrote: > > On Sun, Jan 21, 2024 at 05:57:42PM +0100, David Wronek wrote: > > Document the compatible for the UFS found on SC7180. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: David Wronek <davidwronek@gmail.com> > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > Should have been picked up by SCSI/UFS maintainers, but it > hasn't, so I applied it. And it now triggers schema warnings, because sc7180-ufshc has 7 clocks and 1 reg entries. > > Rob >
On Tue, Feb 13, 2024 at 4:30 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Tue, 13 Feb 2024 at 00:22, Rob Herring <robh@kernel.org> wrote: > > > > On Sun, Jan 21, 2024 at 05:57:42PM +0100, David Wronek wrote: > > > Document the compatible for the UFS found on SC7180. > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Signed-off-by: David Wronek <davidwronek@gmail.com> > > > --- > > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Should have been picked up by SCSI/UFS maintainers, but it > > hasn't, so I applied it. > > And it now triggers schema warnings, because sc7180-ufshc has 7 clocks > and 1 reg entries. And now dropped... Perhaps the dts changes should be too. Maybe QCom maintainers should require a report of dtbs_check on new boards. My comparisons of Linus vs. next warnings often show an increase in QCom warnings. Like right now: linus: arch/arm64/boot/dts/qcom:1990:265 next: arch/arm64/boot/dts/qcom:1610:298 First number is total warnings. Second number is unique warnings (stripping dtb name). Some of this is just mismatch between schemas and dts changes showing up in next, but it doesn't tend to go to 0 as the merge window approaches. I've seen this several cycles. All the data is available from my CI jobs, and I regularly look at the diff with this: $ less ~/bin/gl-diff-dtb-warnings #!/bin/sh [ -z "$1" ] && { echo "Missing arch!"; exit 1; } arch="$1" job="job-dtbs-check" logfile="platform-warnings.log" # url <branch> <arch> url() { local branch="$1" local arch="$2" echo "https://gitlab.com/robherring/linux-dt/-/jobs/artifacts/${branch}/raw/${logfile}?job=${job}%3A+%5B${arch}%5D" } curl -Ls -o orig.log $(url linus ${arch}) curl -Ls -o next.log $(url next ${arch}) meld orig.log next.log
On 13/02/2024 19:11, Rob Herring wrote: > On Tue, Feb 13, 2024 at 4:30 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> >> On Tue, 13 Feb 2024 at 00:22, Rob Herring <robh@kernel.org> wrote: >>> >>> On Sun, Jan 21, 2024 at 05:57:42PM +0100, David Wronek wrote: >>>> Document the compatible for the UFS found on SC7180. >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Signed-off-by: David Wronek <davidwronek@gmail.com> >>>> --- >>>> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ >>>> 1 file changed, 2 insertions(+) >>> >>> Should have been picked up by SCSI/UFS maintainers, but it >>> hasn't, so I applied it. >> >> And it now triggers schema warnings, because sc7180-ufshc has 7 clocks >> and 1 reg entries. > > And now dropped... Perhaps the dts changes should be too. > > Maybe QCom maintainers should require a report of dtbs_check on new > boards. My comparisons of Linus vs. next warnings often show an > increase in QCom warnings. Like right now: > > linus: arch/arm64/boot/dts/qcom:1990:265 > next: arch/arm64/boot/dts/qcom:1610:298 I was tracking new dtbs_check warnings on Qualcomm for selected subsystems and for selected boards, but that grew faster than I was able to fix it so I gave up... After all these months and all these review feedbacks many people still do not test their DTS with dtbs_check, so maybe the solution is to start dropping people's patches? Detect new warnings and drop the patch from Qualcomm tree? > > First number is total warnings. Second number is unique warnings > (stripping dtb name). Some of this is just mismatch between schemas > and dts changes showing up in next, but it doesn't tend to go to 0 as > the merge window approaches. I've seen this several cycles. All the > data is available from my CI jobs, and I regularly look at the diff > with this: > > $ less ~/bin/gl-diff-dtb-warnings > #!/bin/sh > > [ -z "$1" ] && { echo "Missing arch!"; exit 1; } > > arch="$1" > > job="job-dtbs-check" > logfile="platform-warnings.log" > > # url <branch> <arch> > url() { > local branch="$1" > local arch="$2" > echo "https://gitlab.com/robherring/linux-dt/-/jobs/artifacts/${branch}/raw/${logfile}?job=${job}%3A+%5B${arch}%5D" > > } > > curl -Ls -o orig.log $(url linus ${arch}) > curl -Ls -o next.log $(url next ${arch}) > meld orig.log next.log That's useful, thanks! Best regards, Krzysztof
On Tue, Feb 13, 2024 at 12:11 PM Rob Herring <robh@kernel.org> wrote: > > On Tue, Feb 13, 2024 at 4:30 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > On Tue, 13 Feb 2024 at 00:22, Rob Herring <robh@kernel.org> wrote: > > > > > > On Sun, Jan 21, 2024 at 05:57:42PM +0100, David Wronek wrote: > > > > Document the compatible for the UFS found on SC7180. > > > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Signed-off-by: David Wronek <davidwronek@gmail.com> > > > > --- > > > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > Should have been picked up by SCSI/UFS maintainers, but it > > > hasn't, so I applied it. > > > > And it now triggers schema warnings, because sc7180-ufshc has 7 clocks > > and 1 reg entries. > > And now dropped... Perhaps the dts changes should be too. > > Maybe QCom maintainers should require a report of dtbs_check on new > boards. My comparisons of Linus vs. next warnings often show an > increase in QCom warnings. Like right now: > > linus: arch/arm64/boot/dts/qcom:1990:265 > next: arch/arm64/boot/dts/qcom:1610:298 Still a bunch of warnings in next. This binding should be resubmitted with fixes or the dts changes dropped. Rob
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 10c146424baa..9a4f2b43e155 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -27,6 +27,7 @@ properties: - qcom,msm8996-ufshc - qcom,msm8998-ufshc - qcom,sa8775p-ufshc + - qcom,sc7180-ufshc - qcom,sc7280-ufshc - qcom,sc8280xp-ufshc - qcom,sdm845-ufshc @@ -214,6 +215,7 @@ allOf: compatible: contains: enum: + - qcom,sc7180-ufshc - qcom,sm6115-ufshc then: properties: