| Message ID | 20240306021333.1128448-1-bolan.wang@fibocom.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | USB: serial: option: add Fibocom FM135-GL variants | expand |
On 2024-03-06 09:13, bolan wang wrote: > Update the USB serial option driver support for the Fibocom > FM135-GL > LTE modules as there are actually several different variants. > - VID:PID 2cb7:01a1, FM135-GL are laptop M.2 cards (with > MBIM interfaces for /Linux/Chrome OS) > - VID:PID 2cb7:0115, FM135-GL for laptop debug M.2 cards(with adb > interface for /Linux/Chrome OS) > > 0x01a1: mbim > 0x0115: mbim, diag, at, pipe, adb > > Signed-off-by: bolan wang <bolan.wang@fibocom.com> > --- > drivers/usb/serial/option.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index 2ae124c49d44..0981b8d8020c 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -2267,7 +2267,9 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0xff, 0x30) }, /* Fibocom FG150 Diag */ > { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0, 0) }, /* Fibocom FG150 AT */ > { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0111, 0xff) }, /* Fibocom FM160 (MBIM mode) */ > + { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0115, 0xff) }, /* Fibocom FM135 (laptop MBIM) */ > { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a0, 0xff) }, /* Fibocom NL668-AM/NL652-EU (laptop MBIM) */ > + { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a1, 0xff) }, /* Fibocom FM135-GL (MBIM mode) */ > { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a2, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */ > { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a3, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */ > { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a4, 0xff), /* Fibocom FM101-GL (laptop MBIM) */ If the device with pid 0x01a1 only has an mbim interface as you have indicated then why do you add it to the option serial driver? thanks Lars
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 2ae124c49d44..0981b8d8020c 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -2267,7 +2267,9 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0xff, 0x30) }, /* Fibocom FG150 Diag */ { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0, 0) }, /* Fibocom FG150 AT */ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0111, 0xff) }, /* Fibocom FM160 (MBIM mode) */ + { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0115, 0xff) }, /* Fibocom FM135 (laptop MBIM) */ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a0, 0xff) }, /* Fibocom NL668-AM/NL652-EU (laptop MBIM) */ + { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a1, 0xff) }, /* Fibocom FM135-GL (MBIM mode) */ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a2, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a3, 0xff) }, /* Fibocom FM101-GL (laptop MBIM) */ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a4, 0xff), /* Fibocom FM101-GL (laptop MBIM) */
Update the USB serial option driver support for the Fibocom FM135-GL LTE modules as there are actually several different variants. - VID:PID 2cb7:01a1, FM135-GL are laptop M.2 cards (with MBIM interfaces for /Linux/Chrome OS) - VID:PID 2cb7:0115, FM135-GL for laptop debug M.2 cards(with adb interface for /Linux/Chrome OS) 0x01a1: mbim 0x0115: mbim, diag, at, pipe, adb Signed-off-by: bolan wang <bolan.wang@fibocom.com> --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+)