| Message ID | 20240306203348.65776-10-eric.auger@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | VIRTIO-IOMMU: Introduce aw-bits and granule options | expand |
On 6/3/24 21:32, Eric Auger wrote: > Document the new aw-bits option. > > Signed-off-by: Eric Auger <eric.auger@redhat.com> > Reviewed-by: Cédric Le Goater <clg@redhat.com> > > --- > > v4 -> v5 > - tweek the aw-bits option description according to Cédric's > suggestion > --- > qemu-options.hx | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 757df3eac0..87959ede08 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1180,6 +1180,9 @@ SRST > This decides the default granule to be be exposed by the > virtio-iommu. If host, the granule matches the host page size. > > + ``aw-bits=val`` (val between 32 and 64, default depends on machine) > + This decides the address width of IOVA address space. It defaults "It defaults"? IMO this should be squashed in patch 6/9 "virtio-iommu: Add an option to define the input range width". > ERST > > DEF("name", HAS_ARG, QEMU_OPTION_name,
On 3/6/24 21:48, Philippe Mathieu-Daudé wrote: > On 6/3/24 21:32, Eric Auger wrote: >> Document the new aw-bits option. >> >> Signed-off-by: Eric Auger <eric.auger@redhat.com> >> Reviewed-by: Cédric Le Goater <clg@redhat.com> >> >> --- >> >> v4 -> v5 >> - tweek the aw-bits option description according to Cédric's >> suggestion >> --- >> qemu-options.hx | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/qemu-options.hx b/qemu-options.hx >> index 757df3eac0..87959ede08 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -1180,6 +1180,9 @@ SRST >> This decides the default granule to be be exposed by the >> virtio-iommu. If host, the granule matches the host page size. >> + ``aw-bits=val`` (val between 32 and 64, default depends on >> machine) >> + This decides the address width of IOVA address space. It >> defaults > > "It defaults"? Yes needs to be removed. > > IMO this should be squashed in patch 6/9 "virtio-iommu: Add an option > to define the input range width". in [6/9] the default does not yet depend on machine, hence my choice to keep it separate and after 8/9 Eric > >> ERST >> DEF("name", HAS_ARG, QEMU_OPTION_name, >
diff --git a/qemu-options.hx b/qemu-options.hx index 757df3eac0..87959ede08 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1180,6 +1180,9 @@ SRST This decides the default granule to be be exposed by the virtio-iommu. If host, the granule matches the host page size. + ``aw-bits=val`` (val between 32 and 64, default depends on machine) + This decides the address width of IOVA address space. It defaults + ERST DEF("name", HAS_ARG, QEMU_OPTION_name,