mbox series

[net-next,v2,0/2] tcp: add two missing addresses when using trace

Message ID 20240304092934.76698-1-kerneljasonxing@gmail.com (mailing list archive)
Headers show
Series tcp: add two missing addresses when using trace | expand

Message

Jason Xing March 4, 2024, 9:29 a.m. UTC
From: Jason Xing <kernelxing@tencent.com>

When I reviewed other people's patch [1], I noticed that similar things
also happen in tcp_event_skb class and tcp_event_sk_skb class. They
don't print those two addrs of skb/sk which already exist.

In this patch, I just do as other trace functions do, like
trace_net_dev_start_xmit(), to know the exact flow or skb we would like
to know in case some systems doesn't support BPF programs well or we
have to use /sys/kernel/debug/tracing only for some reasons.

[1]
Link: https://lore.kernel.org/netdev/CAL+tcoAhvFhXdr1WQU8mv_6ZX5nOoNpbOLAB6=C+DB-qXQ11Ew@mail.gmail.com/

v2
Link: https://lore.kernel.org/netdev/CANn89iJcScraKAUk1GzZFoOO20RtC9iXpiJ4LSOWT5RUAC_QQA@mail.gmail.com/
1. change the description.

Jason Xing (2):
  tcp: add tracing of skb/skaddr in tcp_event_sk_skb class
  tcp: add tracing of skbaddr in tcp_event_skb class

 include/trace/events/tcp.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 7, 2024, 2:40 p.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Mon,  4 Mar 2024 17:29:32 +0800 you wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> When I reviewed other people's patch [1], I noticed that similar things
> also happen in tcp_event_skb class and tcp_event_sk_skb class. They
> don't print those two addrs of skb/sk which already exist.
> 
> In this patch, I just do as other trace functions do, like
> trace_net_dev_start_xmit(), to know the exact flow or skb we would like
> to know in case some systems doesn't support BPF programs well or we
> have to use /sys/kernel/debug/tracing only for some reasons.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/2] tcp: add tracing of skb/skaddr in tcp_event_sk_skb class
    https://git.kernel.org/netdev/net-next/c/4e441bb8aca1
  - [net-next,v2,2/2] tcp: add tracing of skbaddr in tcp_event_skb class
    https://git.kernel.org/netdev/net-next/c/0ab544b6f055

You are awesome, thank you!