diff mbox series

[3/5] target/sparc/cpu: Improve the CPU help text

Message ID 20240307174334.130407-4-thuth@redhat.com (mailing list archive)
State New, archived
Headers show
Series Sparc CPU naming and help text improvements | expand

Commit Message

Thomas Huth March 7, 2024, 5:43 p.m. UTC
Remove the unnecessary "Sparc" at the beginning of the line and
put the chip information into parentheses so that it is clearer
which part of the line have to be passed to "-cpu" to specify a
different CPU.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2141
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 target/sparc/cpu.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Philippe Mathieu-Daudé March 7, 2024, 6:46 p.m. UTC | #1
On 7/3/24 18:43, Thomas Huth wrote:
> Remove the unnecessary "Sparc" at the beginning of the line and
> put the chip information into parentheses so that it is clearer
> which part of the line have to be passed to "-cpu" to specify a
> different CPU.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2141
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   target/sparc/cpu.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Richard Henderson March 7, 2024, 9:31 p.m. UTC | #2
On 3/7/24 07:43, Thomas Huth wrote:
> Remove the unnecessary "Sparc" at the beginning of the line and
> put the chip information into parentheses so that it is clearer
> which part of the line have to be passed to "-cpu" to specify a
> different CPU.
> 
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/2141
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
>   target/sparc/cpu.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
diff mbox series

Patch

diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index ae30cded22..6650248ffe 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -576,9 +576,10 @@  void sparc_cpu_list(void)
 {
     unsigned int i;
 
+    qemu_printf("Available CPU types:\n");
     for (i = 0; i < ARRAY_SIZE(sparc_defs); i++) {
-        qemu_printf("Sparc %16s IU " TARGET_FMT_lx
-                    " FPU %08x MMU %08x NWINS %d ",
+        qemu_printf(" %-20s (IU " TARGET_FMT_lx
+                    " FPU %08x MMU %08x NWINS %d) ",
                     sparc_defs[i].name,
                     sparc_defs[i].iu_version,
                     sparc_defs[i].fpu_version,