| Message ID | 20240311112437.3813987-2-leitao@debian.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 195f88c57737f16217b5dece054a4cfd74c33550 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] vxlan: Do not alloc tstats manually | expand |
>-----Original Message----- >From: Breno Leitao <leitao@debian.org> >Sent: Monday, March 11, 2024 4:55 PM >To: David S. Miller <davem@davemloft.net>; Eric Dumazet ><edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni ><pabeni@redhat.com> >Cc: keescook@chromium.org; Ido Schimmel <idosch@nvidia.com>; Nikolay >Aleksandrov <razor@blackwall.org>; Amit Cohen <amcohen@nvidia.com>; Petr >Machata <petrm@nvidia.com>; Jiri Benc <jbenc@redhat.com>; Beniamino >Galvani <b.galvani@gmail.com>; Gavin Li <gavinl@nvidia.com>; open >list:NETWORKING DRIVERS <netdev@vger.kernel.org>; open list <linux- >kernel@vger.kernel.org> >Subject: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic >.ndo_get_stats64 > >Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is >configured") moved the callback to dev_get_tstats64() to net core, so, >unless the driver is doing some custom stats collection, it does not >need to set .ndo_get_stats64. > >Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it >doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 >function pointer. > >Signed-off-by: Breno Leitao <leitao@debian.org> Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> ...
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index 6f26003a3064..3495591a5c29 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -3214,7 +3214,6 @@ static const struct net_device_ops vxlan_netdev_ether_ops = { .ndo_open = vxlan_open, .ndo_stop = vxlan_stop, .ndo_start_xmit = vxlan_xmit, - .ndo_get_stats64 = dev_get_tstats64, .ndo_set_rx_mode = vxlan_set_multicast_list, .ndo_change_mtu = vxlan_change_mtu, .ndo_validate_addr = eth_validate_addr, @@ -3238,7 +3237,6 @@ static const struct net_device_ops vxlan_netdev_raw_ops = { .ndo_open = vxlan_open, .ndo_stop = vxlan_stop, .ndo_start_xmit = vxlan_xmit, - .ndo_get_stats64 = dev_get_tstats64, .ndo_change_mtu = vxlan_change_mtu, .ndo_fill_metadata_dst = vxlan_fill_metadata_dst, };
Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is configured") moved the callback to dev_get_tstats64() to net core, so, unless the driver is doing some custom stats collection, it does not need to set .ndo_get_stats64. Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 function pointer. Signed-off-by: Breno Leitao <leitao@debian.org> --- drivers/net/vxlan/vxlan_core.c | 2 -- 1 file changed, 2 deletions(-)