| Message ID | 20240312023326.224504-2-me@jwang.link (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 861b3415e4dee06cc00cd1754808a7827b9105bf |
| Headers | show |
| Series | Revert "ASoC: amd: yc: add new YC platform variant (0x63) support" | expand |
On Tue, Mar 12, 2024 at 10:33:25AM +0800, Jiawei Wang wrote: > This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc. Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read. > Lenovo 21J2 uses the Pink Sardine (PS) platform, not Yellow Carp > (YC). Thanks to Mukunda Vijendar [1] for pointing this out. > > Lenovo 21J2 should not be in YC's quirk table. This doesn't apply against current code, please check and resend - there was another quirk went in yesterday which might also need to be reverted.
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 90360f8b3e81..1d1452c29ed0 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "21HY"), } }, - { - .driver_data = &acp6x_card, - .matches = { - DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "21J2"), - } - }, { .driver_data = &acp6x_card, .matches = {
This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc. Lenovo 21J2 uses the Pink Sardine (PS) platform, not Yellow Carp (YC). Thanks to Mukunda Vijendar [1] for pointing this out. Lenovo 21J2 should not be in YC's quirk table. Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1] Signed-off-by: Jiawei Wang <me@jwang.link> --- sound/soc/amd/yc/acp6x-mach.c | 7 ------- 1 file changed, 7 deletions(-)